mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #112] Whoogle not detected as OpenSearch compatible for Chromium-based browsers #82
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#82
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pluja on GitHub (Jul 31, 2020).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/112
Describe the bug
In order to set a "new search engine" on chromium-based browsers on Android (tested with Bromite and Vanadium) you need to visit an OpenSearch-compatible search engine and then it automatically appears on the "search-engine" list. Whoogle is not detected as a OpenSearch-compatible search engine even with having
/opensearch.xmlTo Reproduce
Steps to reproduce the behavior:
instance.whoogle.tld/search?q=%sSettings > Search EngineDeployment Method
runexecutable (systemd)Version of Whoogle Search
Smartphone (please complete the following information):
@pluja commented on GitHub (Jul 31, 2020):
I've been testing and it seems is not a problem with only Whoogle. I will keep testing and get back with new info.
@TobiasDax commented on GitHub (Aug 8, 2020):
Also the
opensearch.xmlfile can not be downloaded by firefoy to setup whoogle as a search engine.I guess this is connected, but i can not be sure since i have whoogle running in a docker.
@benbusby commented on GitHub (Aug 15, 2020):
I managed to figure this out after a bit of trial and error. It looks like Chrome doesn't allow opensearch templates to specify a
methodparameter alongside the search/suggestion URLs, even though it is typically a supported parameter. I confirmed this manually, but there's also an indication that they only search GET requests mentioned here (no explanation for why though).Anyways, removing the
method=" {{ request_type }} "section from the opensearch.xml template resulted in Chrome automatically importing the search engine (usually with search suggestion functionality as well, though this was hit or miss in the few times I tried it).I'm not sure to what extent this rule applies to other Chromium based browsers, since @botnet88 was able to get the default template working in ungoogled-chromium, but I've updated the template to exclude the method specification altogether if it isn't set to "post" (see
e471b012a0).So if you're encountering this issue, try enabling the "GET requests only" config, then close your browser and re-open it to your Whoogle url. Chrome should then detect it as a valid opensearch format at that point.
(@FoxxMD)
@FoxxMD commented on GitHub (Aug 17, 2020):
Thanks for the hard work Ben! I'm using the
betatag on dockerhub, I hope that one is up to date. With my chrome install I did:Nothing happened -- should I see any indication that it "worked"? I have re-added the manual entry for the time being.
@benbusby commented on GitHub (Aug 17, 2020):
There isn't any immediate visual indication, but it should appear in the list of available search engines after visiting the URL with the updated configuration -- at least, that's what happened for me. Could you verify that the opensearch template (
<whoogle url>/opensearch.xml) doesn't contain amethodparameter for the search/suggestion urls?@FoxxMD commented on GitHub (Aug 20, 2020):
I can verify it does not have the method param but it's also not adding a search engine entry..
@pluja commented on GitHub (Aug 22, 2020):
For me it is not adding it as a search engine also...
@benbusby commented on GitHub (Aug 24, 2020):
Ah okay. I'll revisit this again soon and see if I can't figure out more details.
@benbusby commented on GitHub (Nov 19, 2020):
Going to close this one now, as the discussion in #147 indicates that it has been fixed.