[PR #202] [MERGED] add basic keyboard support #809

Closed
opened 2026-02-25 20:36:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/benbusby/whoogle-search/pull/202
Author: @tborychowski
Created: 2/14/2021
Status: Merged
Merged: 2/20/2021
Merged by: @benbusby

Base: developHead: develop


📝 Commits (3)

  • 0471809 add basic keyboard support
  • 3958e60 Merge branch 'develop' into develop
  • 4bbfc8c fix 'j' and 'k' inside search input

📊 Changes

3 files changed (+53 additions, -2 deletions)

View changed files

📝 app/static/css/header.css (+6 -0)
app/static/js/keyboard.js (+44 -0)
📝 app/templates/display.html (+3 -2)

📄 Description

This adds basic keyboard support on the search results page:

  • ArrowUp or k - focus previous result
  • ArrowDown or j - focus next result
  • / focus search box

Because this just focuses links in the search result items hitting Enter (or ctrl/cmd + Enter) when an item is focused - will open the search result (because the link is already focused and this is browser's default behaviour).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/benbusby/whoogle-search/pull/202 **Author:** [@tborychowski](https://github.com/tborychowski) **Created:** 2/14/2021 **Status:** ✅ Merged **Merged:** 2/20/2021 **Merged by:** [@benbusby](https://github.com/benbusby) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (3) - [`0471809`](https://github.com/benbusby/whoogle-search/commit/04718099f4e869429cc4c79eb2b1461d9996099c) add basic keyboard support - [`3958e60`](https://github.com/benbusby/whoogle-search/commit/3958e607de57e854efd2dc99a53defa6a69ddffe) Merge branch 'develop' into develop - [`4bbfc8c`](https://github.com/benbusby/whoogle-search/commit/4bbfc8c8f72fae347eb90ce28b33130bb0a0dfa9) fix 'j' and 'k' inside search input ### 📊 Changes **3 files changed** (+53 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/static/css/header.css` (+6 -0) ➕ `app/static/js/keyboard.js` (+44 -0) 📝 `app/templates/display.html` (+3 -2) </details> ### 📄 Description This adds basic keyboard support on the search results page: - `ArrowUp` or `k` - focus previous result - `ArrowDown` or `j` - focus next result - `/` focus search box Because this just focuses links in the search result items hitting `Enter` (or ctrl/cmd + Enter) when an item is focused - will open the search result (because the link is already focused and this is browser's default behaviour). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 20:36:47 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/whoogle-search#809
No description provided.