mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[PR #96] [MERGED] Added ddg-style !bang-operators #785
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#785
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/benbusby/whoogle-search/pull/96
Author: @marvinborner
Created: 6/25/2020
Status: ✅ Merged
Merged: 10/13/2020
Merged by: @benbusby
Base:
develop← Head:develop📝 Commits (5)
dd9d87dAdded ddg-style !bang-operators5575bcdMerge branch 'develop' into develop348301fAdded bang operator list generator2126742Merge branch 'develop' into developae05e8fFinished basic implementation of DDG bang feature📊 Changes
7 files changed (+70 additions, -2 deletions)
View changed files
📝
.gitignore(+1 -0)📝
app/__init__.py(+8 -0)📝
app/routes.py(+11 -0)📝
app/static/js/autocomplete.js(+8 -2)➕
app/utils/gen_ddg_bangs.py(+26 -0)📝
app/utils/routing_utils.py(+6 -0)📝
test/test_routes.py(+10 -0)📄 Description
I've just found this project and immediately fell in love with it!
I'm a long-time duckduckgo user and would love to use the famous 13.000+ !bang operators (if you don't know them, look them up - they're awesome!). While there is the "I'm feeling lucky"-bang already (#35), all the other operators are still missing.
I've created this pull request as a kind of proof of concept and it's definitely not mergeable yet. It uses hardcoded operators and the functions are scattered around in the code (I'm not that comfortable with the codebase, yet). The best-case-scenario for me (personally) would be the ability to use all of the ddg !bang operators, and I'm sure that many others would love this, too.
Basically, this is a general discussion whether this feature should get implemented and how exactly this could be accomplished without having a giant list of operators in the source-code.
Thanks for considering the implementation of this feature.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.