[PR #38] [MERGED] Fixed missing host parameter bug. #772

New issue

Closed

opened 2026-02-25 20:36:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:36:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/benbusby/whoogle-search/pull/38
Author: @Atticus-
Created: 5/13/2020
Status: ✅ Merged
Merged: 5/13/2020
Merged by: @benbusby

Base: master ← Head: master

📝 Commits (1)

d1d0ed5 Fixed missing host parameter bug.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 whoogle-search (+1 -1)

📄 Description

Fixes issue #37. Copied from comment there:

We don't see logs because python buffers its output. If we add a -u to line 24 of whoogle-search we can see the problem in the logs:
whoogle-search    | Serving on http://localhost:5000
During #32 the --host 0.0.0.0 argument was left out, so the webserver only listens on localhost (despite docker exposing and publishing the port). The fix is to change line 24 in whoogle-search to:
python3 -um app --host "0.0.0.0" --port $PORT
Happy to send a PR if you'd like.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/benbusby/whoogle-search/pull/38 **Author:** [@Atticus-](https://github.com/Atticus-) **Created:** 5/13/2020 **Status:** ✅ Merged **Merged:** 5/13/2020 **Merged by:** [@benbusby](https://github.com/benbusby) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`d1d0ed5`](https://github.com/benbusby/whoogle-search/commit/d1d0ed59bca54483449547f635ffd5d966bd5acf) Fixed missing host parameter bug. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `whoogle-search` (+1 -1) </details> ### 📄 Description Fixes issue #37. Copied from comment there: > We don't see logs because python buffers its output. If we add a -u to line 24 of `whoogle-search` we can see the problem in the logs: > > ``` > whoogle-search | Serving on http://localhost:5000 > ``` > > During #32 the `--host 0.0.0.0` argument was left out, so the webserver only listens on localhost (despite docker exposing and publishing the port). The fix is to change line 24 in `whoogle-search` to: > > ``` > python3 -um app --host "0.0.0.0" --port $PORT > ``` > > Happy to send a PR if you'd like. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>