[PR #32] [MERGED] Swap out Flask's default web server for Waitress #767

New issue

Closed

opened 2026-02-25 20:36:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:36:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/benbusby/whoogle-search/pull/32
Author: @RealOrangeOne
Created: 5/12/2020
Status: ✅ Merged
Merged: 5/12/2020
Merged by: @benbusby

Base: master ← Head: waitress

📝 Commits (4)

5708f78 Ignore venv when building docker file
9182f11 Remove reference to 8888 port
bee8859 Use waitress rather than Flask's built in web server
28dfe87 Actually add waitress to requirements

📊 Changes

7 files changed (+20 additions, -14 deletions)

View changed files

📝 .dockerignore (+1 -0)
📝 README.md (+5 -5)
➕ app/__main__.py (+3 -0)
📝 app/routes.py (+8 -5)
📝 docker-compose.yml (+1 -1)
📝 requirements.txt (+1 -0)
📝 whoogle-search (+1 -3)

📄 Description

Flask's dev server isn't designed for production use, in fact it's actively discouraged.

Waitress however is.

Gunicorn was also an option, but as there's multiple entrypoints for this application, and Gunicorn doesn't have a stable Python API, it wasn't viable. It's also a bit overkill for an application of this scale.

Also migrated the default port from 8888 to 5000. 5000 was used in more places. Rather than having 2 ports defined, it now just uses 1 everywhere.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/benbusby/whoogle-search/pull/32 **Author:** [@RealOrangeOne](https://github.com/RealOrangeOne) **Created:** 5/12/2020 **Status:** ✅ Merged **Merged:** 5/12/2020 **Merged by:** [@benbusby](https://github.com/benbusby) **Base:** `master` ← **Head:** `waitress` --- ### 📝 Commits (4) - [`5708f78`](https://github.com/benbusby/whoogle-search/commit/5708f78ae6a21a899fcedc945dacc61f43f1b044) Ignore venv when building docker file - [`9182f11`](https://github.com/benbusby/whoogle-search/commit/9182f1108f83abda36166e11607d75dc6e95819c) Remove reference to 8888 port - [`bee8859`](https://github.com/benbusby/whoogle-search/commit/bee8859b949b55e8c07246c144b880c5d55818dc) Use waitress rather than Flask's built in web server - [`28dfe87`](https://github.com/benbusby/whoogle-search/commit/28dfe876dfd3ea4cce16a9037eac0e4379d3ce0a) Actually add waitress to requirements ### 📊 Changes **7 files changed** (+20 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `.dockerignore` (+1 -0) 📝 `README.md` (+5 -5) ➕ `app/__main__.py` (+3 -0) 📝 `app/routes.py` (+8 -5) 📝 `docker-compose.yml` (+1 -1) 📝 `requirements.txt` (+1 -0) 📝 `whoogle-search` (+1 -3) </details> ### 📄 Description Flask's dev server isn't designed for production use, in fact it's actively discouraged. Waitress however is. Gunicorn was also an option, but as there's multiple entrypoints for this application, and Gunicorn doesn't have a stable Python API, it wasn't viable. It's also a bit overkill for an application of this scale. Also migrated the default port from 8888 to 5000. 5000 was used in more places. Rather than having 2 ports defined, it now just uses 1 everywhere. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>