mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #1214] Dark Mode broken? #725
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#725
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @itguy327 on GitHub (Jan 17, 2025).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/1214
Not sure exactly when it happened but now results are always with a white background on desktop even with System and Chrome set to Dark and the WHOOGLE_CONFIG_THEME=dark variable set
Thank you for your work.
@benbusby commented on GitHub (Jan 17, 2025):
Yeah, results are going to start looking a bit odd while #1211 is being investigated. Basically there's not a consistent way to ensure how results will look anymore since Whoogle now has to use different User Agents in order to fetch search results, and using different User Agents returns differently styled results from Google.
Once there's a more stable approach to fetching results, I'll look into ways to fix the styling of the results.
@itguy327 commented on GitHub (Jan 17, 2025):
Thank you. I'm sorry google is making life miserable for you.
Appreciate you
On Fri, Jan 17, 2025 at 4:18 PM Ben Busby @.***> wrote:
@Narkoleptika commented on GitHub (Jan 18, 2025):
This appears to be the result of
self.theme = os.getenv('WHOOGLE_CONFIG_THEME', 'system')being replaced withself.theme = kwargs.get('theme', '')in #1212. The theme value is no longer reading theWHOOGLE_CONFIG_THEMEenvironment variable or defaulting tosystemAFAICT. Other environment variables may have been impacted as well. It's not clear to me if that was a mistake or a deliberate decision due to the unpredictable styling being returned by google so I apologize if I'm stating the obvious here. In any case, thanks for getting these UA changes going so quickly!@benbusby commented on GitHub (Jan 19, 2025):
The changes to the env vars has been reverted, thanks for pointing that out. Feel free to re-open if you're still encountering issues though!