[GH-ISSUE #1214] Dark Mode broken? #725

Closed
opened 2026-02-25 20:36:23 +03:00 by kerem · 4 comments
Owner

Originally created by @itguy327 on GitHub (Jan 17, 2025).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/1214

Not sure exactly when it happened but now results are always with a white background on desktop even with System and Chrome set to Dark and the WHOOGLE_CONFIG_THEME=dark variable set

Thank you for your work.

Originally created by @itguy327 on GitHub (Jan 17, 2025). Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/1214 Not sure exactly when it happened but now results are always with a white background on desktop even with System and Chrome set to Dark and the WHOOGLE_CONFIG_THEME=dark variable set Thank you for your work.
kerem 2026-02-25 20:36:23 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@benbusby commented on GitHub (Jan 17, 2025):

Yeah, results are going to start looking a bit odd while #1211 is being investigated. Basically there's not a consistent way to ensure how results will look anymore since Whoogle now has to use different User Agents in order to fetch search results, and using different User Agents returns differently styled results from Google.

Once there's a more stable approach to fetching results, I'll look into ways to fix the styling of the results.

<!-- gh-comment-id:2599233838 --> @benbusby commented on GitHub (Jan 17, 2025): Yeah, results are going to start looking a bit odd while #1211 is being investigated. Basically there's not a consistent way to ensure how results will look anymore since Whoogle now has to use different User Agents in order to fetch search results, and using different User Agents returns differently styled results from Google. Once there's a more stable approach to fetching results, I'll look into ways to fix the styling of the results.
Author
Owner

@itguy327 commented on GitHub (Jan 17, 2025):

Thank you. I'm sorry google is making life miserable for you.

Appreciate you

On Fri, Jan 17, 2025 at 4:18 PM Ben Busby @.***> wrote:

Yeah, results are going to start looking a bit odd while #1211
https://github.com/benbusby/whoogle-search/issues/1211 is being
investigated. Basically there's not a consistent way to ensure how results
will look anymore since Whoogle now has to use different User Agents in
order to fetch search results, and using different User Agents returns
differently styled results from Google.

Once there's a more stable approach to fetching results, I'll look into
ways to fix the styling of the results.


Reply to this email directly, view it on GitHub
https://github.com/benbusby/whoogle-search/issues/1214#issuecomment-2599233838,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATOIGAZ7LNWVX5NKOWNQJ32LFXSXAVCNFSM6AAAAABVMQXV7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZGIZTGOBTHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

<!-- gh-comment-id:2599235983 --> @itguy327 commented on GitHub (Jan 17, 2025): Thank you. I'm sorry google is making life miserable for you. Appreciate you On Fri, Jan 17, 2025 at 4:18 PM Ben Busby ***@***.***> wrote: > Yeah, results are going to start looking a bit odd while #1211 > <https://github.com/benbusby/whoogle-search/issues/1211> is being > investigated. Basically there's not a consistent way to ensure how results > will look anymore since Whoogle now has to use different User Agents in > order to fetch search results, and using different User Agents returns > differently styled results from Google. > > Once there's a more stable approach to fetching results, I'll look into > ways to fix the styling of the results. > > — > Reply to this email directly, view it on GitHub > <https://github.com/benbusby/whoogle-search/issues/1214#issuecomment-2599233838>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AATOIGAZ7LNWVX5NKOWNQJ32LFXSXAVCNFSM6AAAAABVMQXV7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZGIZTGOBTHA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >
Author
Owner

@Narkoleptika commented on GitHub (Jan 18, 2025):

This appears to be the result of self.theme = os.getenv('WHOOGLE_CONFIG_THEME', 'system') being replaced with self.theme = kwargs.get('theme', '') in #1212. The theme value is no longer reading the WHOOGLE_CONFIG_THEME environment variable or defaulting to system AFAICT. Other environment variables may have been impacted as well. It's not clear to me if that was a mistake or a deliberate decision due to the unpredictable styling being returned by google so I apologize if I'm stating the obvious here. In any case, thanks for getting these UA changes going so quickly!

<!-- gh-comment-id:2599496401 --> @Narkoleptika commented on GitHub (Jan 18, 2025): This appears to be the result of `self.theme = os.getenv('WHOOGLE_CONFIG_THEME', 'system')` being replaced with `self.theme = kwargs.get('theme', '')` in #1212. The theme value is no longer reading the `WHOOGLE_CONFIG_THEME` environment variable or defaulting to `system` AFAICT. Other environment variables may have been impacted as well. It's not clear to me if that was a mistake or a deliberate decision due to the unpredictable styling being returned by google so I apologize if I'm stating the obvious here. In any case, thanks for getting these UA changes going so quickly!
Author
Owner

@benbusby commented on GitHub (Jan 19, 2025):

The changes to the env vars has been reverted, thanks for pointing that out. Feel free to re-open if you're still encountering issues though!

<!-- gh-comment-id:2601006913 --> @benbusby commented on GitHub (Jan 19, 2025): The changes to the env vars has been reverted, thanks for pointing that out. Feel free to re-open if you're still encountering issues though!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/whoogle-search#725
No description provided.