mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #98] [BUG] Search result units not matching country/language setting. #71
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#71
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ilovepancakes95 on GitHub (Jul 6, 2020).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/98
Describe the bug
Data value units not matching typical units used in language/country.
To Reproduce
Steps to reproduce the behavior:
Deployment Method
runexecutableVersion of Whoogle Search
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Running same search directly from Google on same machine running Whoogle does return the correct units (i.e. degrees Fahrenheit/United States Dollar).
@benbusby commented on GitHub (Jul 6, 2020):
Just did some testing with this, and unfortunately it doesn't seem like this is something Whoogle can control directly. The pop up "card" that gets returned at the top of the results page for maps/weather/exchange price/etc all seem to ignore the country param that gets passed over during search. I was able to try the inverse of this -- using "regular" Google search and setting my country/language to be outside of the U.S., and I was still getting American units when I shouldn't.
I'll look into it a bit more this week and see if I can find anything else.
@ilovepancakes95 commented on GitHub (Jul 7, 2020):
I thought maybe Google decides based on IP address "location" although the VPS Whoogle is running on is a US IP and an actual Google search from same machine returns correct units so I'm stumped. Also, where can we send you some money for a beer and pizza? Thanks for your constant dedication to this project. 😃
@benbusby commented on GitHub (Jul 9, 2020):
That's odd...hmmm. Well, I'm in the middle of moving over a lot of my sites to new servers in new locations, so I'll continue to keep an eye out for why this could be happening. I've migrated my Whoogle instance a lot over the last few months and haven't encountered it, but maybe I've just been lucky.
My pleasure! I wish I could dedicate a bit more time to it, but my free time is a bit scarce atm with work, other projects, plus moving. I have a paypal donation page set up, but let me know if there's a different way you'd prefer. Either way I greatly appreciate it.
@ilovepancakes95 commented on GitHub (Jul 9, 2020):
If I search "bitcoin price usd" it does show result in USD. And probably unrelated but weather searches do only show current condition and temp, not the full forecast card that google searches show.
PayPal is fine, unless you would prefer crypto. Some beer and pizza headed your way soon.
@benbusby commented on GitHub (Jul 13, 2020):
Nah just PayPal is fine with me for now. Thanks a bunch!
Will keep you posted if I find a solution for this, but still am having a hard time reproducing it on my newest infrastructure.
@ilovepancakes95 commented on GitHub (Jul 13, 2020):
Ahh interesting, I thought it was doing same thing on your end just not obeying other countries. So you get American units when you search with cards no matter which country you have Whoogle set to? Very weird then I would randomly get Ugandan units and Celsius when searching.
On another, slightly related note, I don't get some cards at all, like typing a FedEx or USPS or UPS tracking number into Whoogle doesn't return the cool package tracking card and link to further info on the carrier's site. Let me know if you want a separate issue opened for that one.
@benbusby commented on GitHub (Dec 27, 2020):
Hey again -- I still haven't been able to replicate this issue, so I'm going to close it for now. I'll keep an eye out for it though and let you know if that changes.
I did finally get around to implementing basic support for detecting tracking numbers though, so not all bad news!
@ilovepancakes95 commented on GitHub (Dec 28, 2020):
Hello! Thanks for the follow-up. It actually has seemed to be working normally the past couple months. Not sure if it changed after update to latest release back then or something else happened to fix it, but I do get USD when searching "bitcoin" for example now, and temps in F when searching weather.
Awesome on package tracking, will check that out. Regarding weather, would be great to get the full interactive forecast "widget" that real google provides when searching "weather san francisco" for example.