[GH-ISSUE #1098] [FEATURE] Option to disable retrieval of favicons #668

Closed
opened 2026-02-25 20:36:16 +03:00 by kerem · 2 comments
Owner

Originally created by @milksteakjellybeans on GitHub (Nov 11, 2023).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/1098

With 0.8.4 the search page will include the favicons of the results. With my use case we have a central search service that has access to google via whoogle, but only out to google. The new favicon feature pulls the icons direct from the various sites.

I would love to have an option to disable that fetching for use cases like ours where we expect and allow this service to communicate with google only.

As a hack, I've made a change to short circuit out of favicon fetching on our local instance.

246,248 filter.py
<        # Skip empty, parentless, or internal links
<        if not link or not link.parent or not link['href'].startswith('http'):
<            return
---
>        # Skip empty, parentless, or internal links
>        if 1 or not link or not link.parent or not link['href'].startswith('http'):
>            return
Originally created by @milksteakjellybeans on GitHub (Nov 11, 2023). Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/1098 With 0.8.4 the search page will include the favicons of the results. With my use case we have a central search service that has access to google via whoogle, but only out to google. The new favicon feature pulls the icons direct from the various sites. I would love to have an option to disable that fetching for use cases like ours where we expect and allow this service to communicate with google only. As a hack, I've made a change to short circuit out of favicon fetching on our local instance. ``` 246,248 filter.py < # Skip empty, parentless, or internal links < if not link or not link.parent or not link['href'].startswith('http'): < return --- > # Skip empty, parentless, or internal links > if 1 or not link or not link.parent or not link['href'].startswith('http'): > return ```
kerem 2026-02-25 20:36:16 +03:00
Author
Owner

@newtoallofthis123 commented on GitHub (Nov 13, 2023):

Actually a good idea! Might also boost the search results delay

<!-- gh-comment-id:1807542057 --> @newtoallofthis123 commented on GitHub (Nov 13, 2023): Actually a good idea! Might also boost the search results delay
Author
Owner

@benbusby commented on GitHub (Dec 20, 2023):

Favicons can now be hidden/disabled using WHOOGLE_SHOW_FAVICONS. For example: WHOOGLE_SHOW_FAVICONS=0 will prevent Whoogle from displaying favicons (and skips the process of fetching them in the first place).

<!-- gh-comment-id:1864952978 --> @benbusby commented on GitHub (Dec 20, 2023): Favicons can now be hidden/disabled using `WHOOGLE_SHOW_FAVICONS`. For example: `WHOOGLE_SHOW_FAVICONS=0` will prevent Whoogle from displaying favicons (and skips the process of fetching them in the first place).
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/whoogle-search#668
No description provided.