mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #87] [BUG] https not available with --build-arg use_https=1 #61
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#61
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gotchai on GitHub (Jun 9, 2020).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/87
Describe the bug
Cannot access to https following the documentation regarding whoogle and docker
To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/benbusby/whoogle-search.git
cd whoogle-search
docker build --build-arg use_https=1 --tag whoogle-search:1.0 .
docker run --publish 5000:5000 --detach --name whoogle-search whoogle-search:1.0
Opening a firefox browser :
https://host:5000 does not work
http://host:5000 is ok
Deployment Method
Version of Whoogle Search
Desktop (please complete the following information):
@benbusby commented on GitHub (Jun 9, 2020):
It looks like you're accessing your whoogle instance using the host address over HTTPS but without generating a certificate beforehand (which would also require a domain name). I'll update the README to clarify that, sorry for the confusion.
If you need HTTPS, you'd want to buy a domain name, make sure the domain points to your hosting setup, and generate a certificate with something like LetsEncrypt to allow HTTPS access with Nginx/Apache/etc.
@benbusby commented on GitHub (Jun 9, 2020):
README updated. Thanks for the report!
@gotchai commented on GitHub (Jun 9, 2020):
Hi thank you for the update
If I use self-signed certificate with mkcert for example on my host, are there any settings to add to the build in docker ?
@benbusby commented on GitHub (Jun 10, 2020):
You'd have to make some modifications to get that working. Since waitress doesn't support decoding https requests, you'd need to use the built in flask server (which isn't very stable, but does have support for decoding these requests). You'd need to always run the instance using the
--debugflag and update the debug server to include an argument likessl_context=('cert.pem', 'key.pem').You'd likely want to add this in
routes.pytowards the bottom ofrun_app():