mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #806] [QUESTION] changing WHOOGLE_ALT_YT=http://192.168.1.5:3000 still inserts https #503
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#503
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @allenwalker3 on GitHub (Jun 30, 2022).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/806
The links are incorrectly resolved to:
https://http//192.168.1.5:3000/watch?v=B3SMn-J5sPwI don't want "https" as my local server running invidious is at http://192.168.1.5:3000. Any ideas?
@DUOLabs333 commented on GitHub (Jun 30, 2022):
WHOOGLE_ALT_*assumes what you've entered is the hostname, and will replace only the hostname, not the scheme, in the results. This means that since Google shows HTTPS urls, the replacements will also be HTTPS. We could see if the scheme is specified, and replace that too, thought it may just be easier to get a HTTPS certificate for your service.@allenwalker3 commented on GitHub (Jun 30, 2022):
Getting a certificate is unnecessary since this is a locally run service, so it would be nice to read the http part correctly and not default to prepending https:// to all urls.
@allenwalker3 commented on GitHub (Jul 2, 2022):
I would be willing to take this work on as a new "feature" , let me know.
@benbusby commented on GitHub (Jul 5, 2022):
@orkowizard if you'd like to work on this, I think it'd be a fairly straightforward fix. The only function that would need changes is
get_site_altinapp/utils/results.py, which could be updated to check if the value set for the alternative has a defined scheme (and if so, remove the scheme used for the targeted site).@benbusby commented on GitHub (Jul 13, 2022):
@orkowizard hope you don't mind, but I just pushed a fix since it was a relatively small change. Hopefully that works for you!
@allenwalker3 commented on GitHub (Jul 13, 2022):
@benbusby Thanks, I actually had the dev environment and tests all setup and running as of yesterday, but hadn't actually done any implementation yet. Maybe the next feature request!
@allenwalker3 commented on GitHub (Jul 19, 2022):
@benbusby The link works but the display still prepends www fyi: