mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #774] [BUG] images and videos broken #488
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#488
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @THENATHE on GitHub (Jun 3, 2022).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/774
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Deployment Method
runexecutableVersion of Whoogle Search
Desktop (please complete the following information):
Additional context
Images, when opening in new tab, redirect to localhost and not the image location
@DUOLabs333 commented on GitHub (Jun 4, 2022):
What version? Can we see the logs? What exactly happens?
@invis-z commented on GitHub (Jun 7, 2022):
@SangeloDev Maybe add your config here since it seems the same issue you are facing?
I suspect the key part is how the Apache/Nginx proxy is set up. However my setup doesn't involve such a proxy so it might need someone else to fix this.
@ratherDashing commented on GitHub (Jun 13, 2022):
if i search for "queen of england" the image points to: http://localhost:5000/element?url=gAAAAABip4XME_snEyJUMg10b_Ceo0Y9Wqy7Tyz0BySixtitgo_38wcUCHAbTimjL1pqowzuxnWsChkTPeao07IYST0UCqYT8diFRE0deK7P23UykHzxTolSB6OvioRVmwTuup-Jws5vm4nmS273TW9-YWGWWcqXkQAoBrvNTOS3cfFvwhRljzNnHui8MezG40z1dtyxUDs9WWzOU1hHIh7tfh2--QfO54tzlFtty0QTH3rin0iADL0=&type=image/png
even though i have my root url setup. so all images are broken since i host this on a different computer than my own.
i am using docker and have nginx hosting my ssl cert and redirecting to whoogle
0.7.1 is the last version that works for me so i am reverting. i've tried 0.7.2 and 0.7.4
@printfuck commented on GitHub (Jun 13, 2022):
I am just now trying to setup my instance and came across the following problem:
It seems, that the
root urlis being applied improperly:with
whoogle_config_urlset tohttps://my.do.mainI get the following image links:with
whoogle_config_urlset tomy.do.mainI get redirection storms until firefox gives up:Without setting it at all, I got this:
My nginx config:
Domain name replaced with my.do.main.
@DUOLabs333 commented on GitHub (Jun 13, 2022):
@printfuck Can you try accessing it by IP? If it works, then it's a nginx issue.
@printfuck commented on GitHub (Jun 13, 2022):
@DUOLabs333 When trying to access it by ip:port, I get an empty response.
docker-compose.yml for reference
@DUOLabs333 commented on GitHub (Jun 13, 2022):
So the service is not even up?
@printfuck commented on GitHub (Jun 13, 2022):
The service is up. I can reach it via domain through nginx.
@DUOLabs333 commented on GitHub (Jun 13, 2022):
But you can't access it with ip:port?
@printfuck commented on GitHub (Jun 13, 2022):
Ok, I'm an idiot. Accessing it locally with ip:port totally works with images loading all right. I messed up my ssh forward.
@DUOLabs333 commented on GitHub (Jun 13, 2022):
So, does everything works?
@printfuck commented on GitHub (Jun 13, 2022):
I still get image links like this:
with my posted config. With
https://my.do.main%2C%20my.do.main/still not being a valid domain.@DUOLabs333 commented on GitHub (Jun 13, 2022):
But with ip:port, does it work as expected?
@DUOLabs333 commented on GitHub (Jun 13, 2022):
Then it's probably something with your nginx config: try only
@printfuck commented on GitHub (Jun 13, 2022):
You're right and thanks for your help so far.
I fixed my problem: my nginx config added the
HostHeader 2 times. Resulting in a variable that looks like "my.do.main, my.do.main".It's a weird error, but something you might want to catch in your backend?
@DUOLabs333 commented on GitHub (Jun 13, 2022):
Oh, I didn't even notice that. I'm not sure whether whoogle should be responsible for checking the correctness of headers.
@printfuck commented on GitHub (Jun 13, 2022):
I also don't think it should. I think you could probably mess up a lot of other web-apps by doing this :D
@DUOLabs333 commented on GitHub (Jun 13, 2022):
Awesome. @ratherDashing Can you send your config (be warned: I don't know much about apache).
@ratherDashing commented on GitHub (Jun 14, 2022):
@DUOLabs333
Thank you!
location / { proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; proxy_set_header Host $host; proxy_set_header X-NginX-Proxy true; proxy_pass http://localhost:5000; }worked for me
@DUOLabs333 commented on GitHub (Jun 14, 2022):
Oh nice! @THENATHE Do you still have this issue?
@nocturn9x commented on GitHub (Jun 21, 2022):
Can confirm adding the headers fixes the problem! Thanks, it was driving me crazy. Whoogle is such a great tool!
@DUOLabs333 commented on GitHub (Jun 21, 2022):
Wonder if this should be posted in the README.