mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #649] [FEATURE] Don't crash when not connected to the internet #414
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#414
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DUOLabs333 on GitHub (Feb 8, 2022).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/649
Describe the feature you'd like to see added
The app should not crash if it can't connect to google.com/github.com
Additional context
Sometimes, as I restart whoogle often (testing new ideas), I don't have WiFi for 5 seconds, and if Whoogle can't connect to github.com, it crashes, forcing me to starting it again.
@DUOLabs333 commented on GitHub (Feb 10, 2022):
It happens here:
update = bsoup(get(app.config['RELEASES_URL']).text, 'html.parser')inroutes.py. I'm not sure what should happen on an error. Do show "Failed to retrieve info"?@benbusby commented on GitHub (Feb 14, 2022):
Fixed as part of a larger refactor that was needed for the latest release/update check.