mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #631] WHOOGLE_CONFIG_TOR is not working #399
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#399
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ngosang on GitHub (Jan 29, 2022).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/631
I was running Whoogle with TOR disabled with the Docker image 0.7.0.
After the update to the latest image (0.7.1) I'm not able to disable Tor with the environment variable
WHOOGLE_CONFIG_TOR.I know there are breaking changes in the docker-compose file but I'm not using those options. This is my docker file and It's running TOR even if I set the environment variable
WHOOGLE_CONFIG_TOR=0@DUOLabs333 commented on GitHub (Jan 30, 2022):
Stop the Whoogle container. Is TOR still running?
@ngosang commented on GitHub (Jan 31, 2022):
You mean stop and start the container? I don't have Tor installed in the host. Tor process is running inside the container. As you can see in my Docker-compose I'm not mapping external volumes.
@DUOLabs333 commented on GitHub (Jan 31, 2022):
Ok, stop the Tor process, then restart the container. Does Tor start?
@ngosang commented on GitHub (Jan 31, 2022):
I restart the container
Tor process is running again
@DUOLabs333 commented on GitHub (Jan 31, 2022):
Ok, I'll look into this.
@DUOLabs333 commented on GitHub (Feb 1, 2022):
Weird -- can you uninstall tor and try again? Paste the logs from the whoogle application itself.
@benbusby commented on GitHub (Feb 1, 2022):
Seems like we should be checking the
WHOOGLE_CONFIG_TORvalue at the beginning ofmisc/tor/start-tor.shand skipping the remainder of the script if the var is set to 0. Otherwise the process gets started independently of Whoogle itself.Edit: That being said, this becomes a bit confusing since
WHOOGLE_CONFIG_TORis just a config setting for enabling/disabling Tor routing, not starting/stopping the service itself. There should maybe be a separate variable to control the Tor service itself.@DUOLabs333 commented on GitHub (Feb 1, 2022):
Tor is only started automatically in the Dockerfile -- that's why I didn't notice the problem on my end.
@ngosang commented on GitHub (Feb 5, 2022):
I can help with testing when you have some kind of fix.
@kapiorr commented on GitHub (Feb 18, 2022):
same for me
@szampardi commented on GitHub (Feb 20, 2022):
creating an executable
start-tor.shfile in the same directory asdocker-compose.ymlwith the following content:and mounting it into the container:
helped get rid of tor
@FlorianWendelborn commented on GitHub (Mar 7, 2022):
@szampardi’s workaround works for me. The container logs no longer get spammed with Tor-related messages.
@dhernan3 commented on GitHub (May 7, 2022):
My start-tor.sh is(sorry I don't know how to format text):
#!/bin/sh if [ $WHOOGLE_CONFIG_TOR == 0 ]; then true else if [ "$(whoami)" != "root" ]; then tor -f /etc/tor/torrc else if (grep alpine /etc/os-release >/dev/null); then rc-service tor start else service tor start fi fi fiThis way I can start tor changing env variable
@ShlomiD83 commented on GitHub (May 9, 2022):
I've used your workaround, the logs aren't spammed with Tor related entries anymore.
I only see 1 line "/bin/sh: misc/tor/start-tor.sh: not found"
is that what I'm supposed to see?