mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #614] [BUG] Saving settings applies a lot of https:// to the URL, so an invalid redirect happens #394
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#394
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dr460nf1r3 on GitHub (Jan 18, 2022).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/614
Describe the bug
After hitting apply when changing settings, the page gets redirected to a not existing URL:
https://search.garudalinux.org/%22https://%22https://%22https://%22https://%22https://%22https://%22https://%22https://%22https://%22https://search.garudalinux.org%22To Reproduce
Steps to reproduce the behavior:
applyDeployment Method
runexecutableVersion of Whoogle Search
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional information:
The following docker-compose.yml is used:
@Albonycal commented on GitHub (Jan 24, 2022):
is that env variable necessary?
doesn't it automatically set that
@dr460nf1r3 commented on GitHub (Jan 24, 2022):
I don't know, I assumed it was since the instance tried to load a CSS file via http instead https. When using a browser with https only mode enabled this gives an ugly warning :/
@Albonycal commented on GitHub (Jan 24, 2022):
hmm, I have also noticed this redirect error, but I ignored it because the settings apply
@dr460nf1r3 commented on GitHub (Jan 24, 2022):
It it still quite a bummer if this happens when showing people the search engine :/
Maybe I should create another issue for that, since it happens a lot?
@benbusby commented on GitHub (Jan 25, 2022):
@dr460nf1r3 on your instance I was able to fix the redirecting issue by removing the double quotes on either end of the root URL. It seems that somehow in setting the
WHOOGLE_CONFIG_URLenvironment variable, the quotes were carried over, which creates an invalid URL when redirecting back to the home page (the root URL is used for redirecting all requests if overwritten).It looks like only docker-compose keeps the quotes intact when setting a variable value, which is bizarre. Setting the variable outside of docker-compose with the quotes works as expected.
That being said, is there any more info you can provide regarding the CSS file that was loaded over http instead of https? I'm not able to replicate that issue either, but would like to investigate if you can send over a screenshot of the network requests when that file is loaded, or something to that effect.
@benbusby commented on GitHub (Feb 1, 2022):
Closing for now, but feel free to reopen if this is still happening even after removing the quotes from the root URL.
@dr460nf1r3 commented on GitHub (Feb 1, 2022):
Hey @benbusby ! I somehow forgot to report back after testing the change. So yes, that resolved the issue with https redirects! :)
I actually wanted to provide you with some logs about the other issue, guess I'll just open another issue to do it properly.