mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #508] [BUG] Results layout with NoJS enabled doesn't look great #327
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#327
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gripped on GitHub (Oct 29, 2021).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/508
Describe the bug
Pictures speak a thousand words. One result takes an entire page.
imho no need for the
<br>'s , no need for the<hr>and no need to display the link address.Without
Still not quite right but I'll get to that.
@gripped commented on GitHub (Oct 29, 2021):
Again imho, the NoJS links should go to the right of the true link
I've been trying to figure it out but alas no.
I've even discovered the joys of a debugger called Pudb but at the moment it's beyond my capabilities.
@benbusby commented on GitHub (Oct 29, 2021):
Hmmm. I think my rationale for adding line breaks and a divider was to create better division between regular and NoJS links on mobile. I don't actually remember anymore though, so I'm fine with changing it to this instead.
@gripped commented on GitHub (Oct 29, 2021):
Cool. It took up a lot of screen estate and, to me, looked untidy. I've a feeling the 'NoJS' feature isn't used by many as I'd have expected someone to have bought the issue up before? Or maybe I'm just finicky?
@benbusby commented on GitHub (Oct 29, 2021):
Yeah, I've been curious if anyone uses that feature as well. My inclination is to think that it is not used very often. I think it would probably get used a lot more if it was refactored to serve as a general website proxy feature that allowed users to open a result in Whoogle itself (using the same
/windowroute), and conditionally enable/disable Javascript depending on user preference. I think there's actually an issue here for that somewhere, and wouldn't be too difficult to implement. Thoughts?@drugal commented on GitHub (Oct 29, 2021):
Two things to take from searx. Morty proxy and filtron . I think people would really like.
Morty is a web content sanitizer proxy.
Filtron protects against bots.
I used them as services outside of docker and everything went fine.
@gripped commented on GitHub (Oct 29, 2021):
Morty is the the reason I wanted to improve the look of the NoJS Layout. #276.
I'm hacking Morty into the NoJS setting (because it's easy). Ideally Whoogle would be able to support a a range of HTML sanitizers. If not develop it's own ? But to be fair NoJS is a sanitizer as well.
Filtron I'm aware of, but don't know a lot about.
As always thanks Ben. Whoogle rocks ;)
@drugal commented on GitHub (Oct 29, 2021):
Yeah, Whoogle rocks!!!