mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #43] Login page for Whoogle #28
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#28
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Panja0 on GitHub (May 13, 2020).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/43
Describe the feature you'd like to see added
Login to Whoogle.
Describe which parts of the project this would modify (front end/back end/configuration/etc)
Probably both?
Additional context
Would it be possible to add a login page to Whoogle?
This way, when my Whoogle server is exposed to the internet it won't be hammered.
You will need to first login before you can use Whoogle.
@s3rverro0m commented on GitHub (May 13, 2020):
You do have the option of using OAuth if you wanted to? That may be an option!
@Panja0 commented on GitHub (May 13, 2020):
Thanks for the quick reply!
I have to look into this... Do you have some more info on this maybe?
@s3rverro0m commented on GitHub (May 13, 2020):
I use Keycloak in front of Traefik. What do you use as a reverse proxy?
Edit: https://www.keycloak.org
@Panja0 commented on GitHub (May 13, 2020):
I'm running Whoogle in Docker.
Docker is running on my Synology which uses NGINX as reverse proxy.
@s3rverro0m commented on GitHub (May 13, 2020):
Check this out: https://edhull.co.uk/blog/2018-06-06/keycloak-nginx — uses docker-compose.
@s3rverro0m commented on GitHub (May 13, 2020):
Granted, adding a login page would be easier as a whole, but at least this will allow you to secure all of your containers. It supports 2FA as well which is a big plus.
@Panja0 commented on GitHub (May 13, 2020):
Thanks! I'll have a look later on. Looks promising. Just like Whoogle itself! :-D
Love it!
I'll leave my enhancement request open.
@benbusby commented on GitHub (May 15, 2020):
I like the idea of this in principle, but (depending on implementation) it might go a bit against the philosophy of keeping this as minimal and lightweight as possible. I can see implementing some form of really basic authentication -- maybe even literally HTTP Basic Auth -- but I'm not sure I'd want to go so far as to create a login page, local user db, etc just for this.
In any case it should definitely be an optional configuration setting to avoid any sort of delay between deployment and actually using the app. I'd even be open to it being set up as username/pw build args passed in the Dockerfile and then used by the Flask server to conditionally prompt for the basic auth dialog.
@Panja0 commented on GitHub (May 15, 2020):
Sounds good! Cheers
Keep up the good work! 😃
@benbusby commented on GitHub (May 15, 2020):
Addressed in #51 (pending merge)