mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 20:25:51 +03:00
[GH-ISSUE #410] [QUESTION] The README advertises "no JavaScript", but the code includes JavaScript #274
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#274
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mariavillosa on GitHub (Sep 1, 2021).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/410
According to the README: "No javascript". It reiterates this a few times throughout the README and elsewhere. And yet:
github.com/benbusby/whoogle-search@68fdd55482/app/templates/display.html (L43-L45)github.com/benbusby/whoogle-search@be3714f074/app/templates/index.html (L20-L21)Perhaps we could make the promise true by removing this and changing the CSP JS policy to
noneinstead ofself.ref:
github.com/benbusby/whoogle-search@9f84a8ad83/app/init.py#L76Just wondering, am newbie, sorry if I'm mistaken!
@federicotorrielli commented on GitHub (Sep 2, 2021):
The "No JavaScript" stands for "No Google JavaScript, No tracking JS code or else"
Cheers~
@alefvanoon commented on GitHub (Sep 3, 2021):
Working fine without any client side JS.
Just remove script frome index.html
Without JS:

Also :
@benbusby commented on GitHub (Sep 15, 2021):
The "no JavaScript" just means "no external JavaScript". There are still scripts used for things like providing search suggestions while the user is typing. That being said, JavaScript isn't used for any crucial features, and the project still works as expected with something like NoScript enabled.
I'll add a note to the readme to clarify the meaning of that.