mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 20:25:51 +03:00
[GH-ISSUE #362] [FEATURE] shadowsocks support #240
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#240
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @specter78 on GitHub (Jun 19, 2021).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/362
Describe the feature you'd like to see added
Shadowsocks proxy support
Additional context
Since many vpns offer shadowsocks support. And to view results from my country.
@DUOLabs333 commented on GitHub (Jan 11, 2022):
Do you want
shadowsocksspecifically (specifying theshadowsocksserver), or are you OK withSOCKSsupport (specifying theshadowsocksclient)? The latter should already be in there (WHOOGLE_PROXY_LOCshould besocks5h, though it probably should be renamed toWHOOGLE_PROXY_TYPE). What do you think @benbusby?@benbusby commented on GitHub (Jan 11, 2022):
WHOOGLE_PROXY_TYPEalready exists for that purpose,WHOOGLE_PROXY_LOCis for specifying the connection details. To addsocks5hsupport, we'd need to updateapp/request.pyto differentiate between that and regularsocks5connection strings though.@DUOLabs333 commented on GitHub (Jan 11, 2022):
Aren't
socks5hpaths the same assocks5paths?@benbusby commented on GitHub (Jan 11, 2022):
I assumed
socks5hneeded to be defined in the connection string (i.e.socks5h://...versussocks5://). I haven't actually looked into it too much yet though, so I could be wrong.@DUOLabs333 commented on GitHub (Jan 11, 2022):
Shouldn't the type be the first part of the connection string, so it doesn't have to be in LOC (it could be just address and port)?
@benbusby commented on GitHub (Jan 11, 2022):
Currently type isn't included in
LOC, but the type is hardcoded tosocks5if it isn't a regular http/https proxy type. But yeah we need to just remove the hardcodedsocks5://part of the current connection string and just use whatever type the user specified.@DUOLabs333 commented on GitHub (Jan 11, 2022):
What do you mean, it looks right to me.
@benbusby commented on GitHub (Mar 1, 2022):
Forgot to actually close this. This should supported by the existing socks proxy support in Whoogle. The shadowsocks server location just has to be defined using the
WHOOGLE_PROXY_LOCandWHOOGLE_PROXY_TYPEenvironment variables.