mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 20:25:51 +03:00
[GH-ISSUE #346] [BUG] Whoogle returns Internal Server error after 0.5.2. Update #230
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#230
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @timespacedecay on GitHub (Jun 3, 2021).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/346
Describe the bug
Whoogle returns 500 Internal Server error after 0.5.2. Update. Docker log shows the following:
To Reproduce
Steps to reproduce the behavior:
Deployment Method
runexecutableVersion of Whoogle Search
Desktop (please complete the following information):
Additional context
Confirmed an issue specifically with 0.5.2; downgrading to 0.5.1 using the :0.5.1 tag results in the expected search behavior and no errors.
@benbusby commented on GitHub (Jun 3, 2021):
Looks like this might be related to the recent upgrade of the
urllibdependency. Pulling0.5.2from scratch works fine for me, and the CI build passed for that tag, so maybe the Python dependencies were erroneously cached for your upgrade. Can you try repulling with--no-cacheto see if that fixes it for you?@timespacedecay commented on GitHub (Jun 4, 2021):
Unfortunately I don't know how to do that - I'm just a pleb on Unraid.
I removed the whoogle-docker and deleted the image. Added it back and it re-downloaded the image. Same issue, with an additional line at the end of the log now:
WARNING:app:404 Not Found: The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.@benbusby commented on GitHub (Jun 4, 2021):
Ah okay, this is actually my mistake. The 0.5.2 release does not actually include the update to urllib after all. Apologies!
I'll get a new release out today with the update and let you know once it's available.
@benbusby commented on GitHub (Jun 4, 2021):
This should now be fixed with tag
0.5.3. Please reopen if you're still having issues!@timespacedecay commented on GitHub (Jun 4, 2021):
Still happening. I tried :latest, no dice, so I forced :0.5.3, still get the same errors in the logs and Internal Server error after pressing search.
I am using the WHOOGLE_PROXY options if that matters, to route traffic through the VPN of another container. Worked fine on 0.5.1.
@benbusby commented on GitHub (Jun 4, 2021):
Ah. The
WHOOGLE_PROXYinfo is very helpful. It looks like this is a known issue with the latest changes to the library I mentioned earlier (https://stackoverflow.com/a/67000726).I'll push another update soon.
@benbusby commented on GitHub (Jun 4, 2021):
Actually are you able to give me some more info on the proxy info you're passing? No private details, but protocol would be helpful at least. From this comment it looks like it could be a user proxy configuration issue, where the user changed the proxy type from
httpstohttpand it began working since their proxy was only configured to accept regular HTTP traffic on port 443.@timespacedecay commented on GitHub (Jun 4, 2021):
WHOOGLE_PROXY_TYPE:httpWHOOGLE_PROXY_LOC:192.168.1.12:8118Should I try https?
Note - I haven't changed anything with the VPN or these proxy settings. I just rolled back to 0.5.1 and it works as expected.
@benbusby commented on GitHub (Jun 4, 2021):
Yes, the issue here is that an update to one of the project's dependencies (which was rolled out after 0.5.1) seems to have made proxy connection details more strict. On 0.5.1, the dependency is set to a prior version where this wasn't an issue. I'd offer to roll back the library to the version that worked for you (the one being used on 0.5.1), but the library was updated because of a security vulnerability.
@benbusby commented on GitHub (Jun 4, 2021):
Actually, after looking into it a bit more, it might be something that Whoogle itself can fix after all. I'm going to look into it a bit more and get back to you.
@benbusby commented on GitHub (Jun 4, 2021):
Can you try again with the
latesttag? I pushed a fix that I confirmed works with a basic Privoxy setup, but want to make sure it's working on your end as well.@timespacedecay commented on GitHub (Jun 4, 2021):
It works! Thanks for your efforts and I appreciate the quick help!