mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 20:25:51 +03:00
[GH-ISSUE #344] [BUG] when using a dutch browser search results return in german #229
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#229
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bruvv on GitHub (Jun 3, 2021).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/344
Describe the bug
When using a dutch browser, the search results return in german. I forced the settings to use english but even then it returns german results.
To Reproduce
Steps to reproduce the behavior:
Deployment Method
runexecutableVersion of Whoogle Search
Desktop (please complete the following information):
I did make a PR to add Dutch translation: https://github.com/benbusby/whoogle-search/pull/343 I am almost 99% sure that it will not help though.
@benbusby commented on GitHub (Jun 3, 2021):
Hmmm, that's odd. How are you hosting your whoogle instance? I'm curious if the specified query language is being ignored by Google and replaced with IP geolocation for some reason.
Can you post the results of
<your whoogle url>/config(obscuring theurlval, if private)? Also just to check, are you using thelatestdocker tag -- the one that includes the changes from your PR?@bruvv commented on GitHub (Jun 3, 2021):
It is hosted with docker with the latest tag it just got updated. Still same issue.
After changing the interface language, trying Dutch and English both fixed the issue by forcing the interface language :)
So when no interface language is selected it should default to something: English not to "something"
This is the config:
@benbusby commented on GitHub (Jun 4, 2021):
As of the new
0.5.3release /614dceeb70the interface language defaults to English if nothing is set in the config menu. Hopefully that clears things up moving forward. Thanks for reporting this!@bruvv commented on GitHub (Jun 4, 2021):
Ah it checks the IP! That could be why I was seeing German. Because I've a VPN via German 😂 could we perhaps use the language of the browser ?
@benbusby commented on GitHub (Jun 4, 2021):
Right. The potential solution of using the browser's language has come up in past discussions, but I'm still not sure of a great way to implement it cleanly. The browser language is accessible with Javascript pretty easily:
but since all configuration is handled server side (including translations), this isn't much help unless loading the initial page load also automatically updates the config by sending the server the current browser language. I guess that's still an option, I just feel like there's probably a better solution that I'm overlooking...
@bruvv commented on GitHub (Jun 8, 2021):
Shall we use this: https://github.com/benbusby/whoogle-search/issues/322 as a discussion on how to implement this dual language people?