mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #316] [BUG] Docker container is unhealthy with basic auth #222
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#222
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @almottier on GitHub (May 14, 2021).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/316
Describe the bug
Docker container is unhealthy when I use basic auth with env var
WHOOGLE_USERandWHOOGLE_PASS.To Reproduce
Deployment Method
Version of Whoogle Search
@nandor-magyar commented on GitHub (May 15, 2021):
The app itself includes some of the responsibilites would be better handled by a separate web-server (nginx or else) imo.
I tried to fix this locally, with using a new route that is just returning "" - the
@auth_requireddecorator is left out.This naturally works and I am happy to send a PR, but I haven't found any formatter/linter guidance in the readme or just missed.
The Dockerfile:
The new route:
@benbusby commented on GitHub (May 18, 2021):
Thanks @nandor-magyar, I just implemented your solution with
1fdf226802(as well as switching to acurlbased healthcheck to avoid some problems that another user encountered withwget).