mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 04:05:57 +03:00
[GH-ISSUE #179] [BUG] settings set by user stored globally #124
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#124
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Jan 21, 2021).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/179
Describe the bug
settings applied by users are set/stored globally/persistently.
To Reproduce
Steps to reproduce the behavior:
user changes setting, clicks apply.
other user opens whoogle from different computer, browser, etc to find that setting applied by previous user has been set globally.
Deployment Method
manual build with run executable.
Version of Whoogle Search
latest from source.
Desktop (please complete the following information):
any device
Smartphone (please complete the following information):
any device.
Additional context
instance is public.
i've also noticed that this issue is not just affecting my instance, but other public instances as well.
mine: https://whoogle.himiko.cloud
other: https://whoogle.sdf.org
@benbusby commented on GitHub (Jan 22, 2021):
Yeah this is a bit of a known issue. The intent for Whoogle was to only ever have individual instances rather than shared public ones, since public instances are incredibly easy for Google to rate limit or block altogether. Eventually I caved and added cookie based configs, with a "base config" that is used if cookies are unable to be set for some reason or are being blocked. Obviously something about this is broken and needs fixing, but figured context would be helpful here for why this is happening in the first place.
@ghost commented on GitHub (Jan 22, 2021):
i set the main config file to read only, i think it fixed it? not exactly sure. anyways, i love whoogle, and yeah i understand that it's not meant for public use.
thanks <3
Sent from my iPhone
@benbusby commented on GitHub (May 5, 2021):
I think this can be closed now with the merging of #295 actually. Public instances can now set their own config settings on the backend and disable client side config changes. Config settings for users who have cookies enabled can also set session specific settings that shouldn't cause any global config changes.