mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 20:25:51 +03:00
[PR #1196] [MERGED] Ensure helm chart can run on Kubernetes >= v1.25 and improve installation steps #1114
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#1114
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/benbusby/whoogle-search/pull/1196
Author: @JoeyC-Dev
Created: 11/4/2024
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @benbusby
Base:
main← Head:main📝 Commits (3)
ec504c3Replacehelm installwithhelm upgrade --install79212f7Migrate old API (autoscaling/v2beta1) to latest API (autoscaling/v2) and add compatibility with old APIb6a52f9Setautoscaling/v2version target tov1.23📊 Changes
2 files changed (+17 additions, -1 deletions)
View changed files
📝
README.md(+1 -1)📝
charts/whoogle/templates/hpa.yaml(+16 -0)📄 Description
Proposed changes:
helm installwithhelm upgrade --install, which can be used on both initial installation and upgradation scenarios.autoscaling/v2beta1Supporting point:
helm upgrade --installv1.24is EOL 16 months ago. (src: Non-Active Branch history)Today if we are using current version of helm chart, it will fail to run if HPA is enabled as the old API is being deleted since
v1.25.autoscaling/v2targetingv1.23asautoscaling/v2is available sincev1.23.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.