[PR #1196] [MERGED] Ensure helm chart can run on Kubernetes >= v1.25 and improve installation steps #1114

Closed
opened 2026-02-25 21:30:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/benbusby/whoogle-search/pull/1196
Author: @JoeyC-Dev
Created: 11/4/2024
Status: Merged
Merged: 1/22/2025
Merged by: @benbusby

Base: mainHead: main


📝 Commits (3)

  • ec504c3 Replace helm install with helm upgrade --install
  • 79212f7 Migrate old API (autoscaling/v2beta1) to latest API (autoscaling/v2) and add compatibility with old API
  • b6a52f9 Set autoscaling/v2 version target to v1.23

📊 Changes

2 files changed (+17 additions, -1 deletions)

View changed files

📝 README.md (+1 -1)
📝 charts/whoogle/templates/hpa.yaml (+16 -0)

📄 Description

Proposed changes:

  1. Replace helm install with helm upgrade --install, which can be used on both initial installation and upgradation scenarios.
  2. Migrate old API to the latest API and add compatibility with old API: autoscaling/v2beta1

Supporting point:

  • It is easier to use if using helm upgrade --install
  • "The autoscaling/v2beta1 API version of HorizontalPodAutoscaler is no longer served as of v1.25." (src: Deprecated API Migration Guide - v1.25 - HorizontalPodAutoscaler) Meantime, v1.24 is EOL 16 months ago. (src: Non-Active Branch history)
    Today if we are using current version of helm chart, it will fail to run if HPA is enabled as the old API is being deleted since v1.25.
    joey [ ~/whoogle-search ]$ helm upgrade --install whoogle ./charts/whoogle
    Error: UPGRADE FAILED: resource mapping not found for name: "whoogle" namespace: "" from "": no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta1"
    ensure CRDs are installed first
    
  • Make autoscaling/v2 targeting v1.23 as autoscaling/v2 is available since v1.23.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/benbusby/whoogle-search/pull/1196 **Author:** [@JoeyC-Dev](https://github.com/JoeyC-Dev) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@benbusby](https://github.com/benbusby) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`ec504c3`](https://github.com/benbusby/whoogle-search/commit/ec504c3708165839f2c5d2c3532aaa7c98b890f6) Replace `helm install` with `helm upgrade --install` - [`79212f7`](https://github.com/benbusby/whoogle-search/commit/79212f77e661f6cc06f1cc07b88be0bff9b6c49a) Migrate old API (autoscaling/v2beta1) to latest API (autoscaling/v2) and add compatibility with old API - [`b6a52f9`](https://github.com/benbusby/whoogle-search/commit/b6a52f9be2bf453e7bdd887cb9b0c6ab368dca10) Set `autoscaling/v2` version target to `v1.23` ### 📊 Changes **2 files changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `charts/whoogle/templates/hpa.yaml` (+16 -0) </details> ### 📄 Description **Proposed changes:** 1. Replace `helm install` with `helm upgrade --install`, which can be used on both initial installation and upgradation scenarios. 2. Migrate old API to the latest API and add compatibility with old API: `autoscaling/v2beta1` **Supporting point:** - It is easier to use if using `helm upgrade --install` - "The autoscaling/v2beta1 API version of HorizontalPodAutoscaler is no longer served as of v1.25." (src: [Deprecated API Migration Guide - v1.25 - HorizontalPodAutoscaler](https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v125)) Meantime, `v1.24` is **EOL** 16 months ago. (src: [Non-Active Branch history](https://kubernetes.io/releases/patch-releases/#non-active-branch-history)) Today if we are using current version of helm chart, it will fail to run if HPA is enabled as the old API is being deleted since `v1.25`. ```bash joey [ ~/whoogle-search ]$ helm upgrade --install whoogle ./charts/whoogle Error: UPGRADE FAILED: resource mapping not found for name: "whoogle" namespace: "" from "": no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta1" ensure CRDs are installed first ``` - Make `autoscaling/v2` targeting `v1.23` as `autoscaling/v2` is available since `v1.23`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 21:30:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/whoogle-search#1114
No description provided.