[PR #1126] [CLOSED] Fix uncaught exception "translation" from Jinja #1083

New issue

Closed

opened 2026-02-25 20:37:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:37:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/benbusby/whoogle-search/pull/1126
Author: @ahmad-alkadri
Created: 3/2/2024
Status: ❌ Closed

Base: main ← Head: fixes/jinja-translation-message

📝 Commits (1)

7f0af09 Fix jinja translation message by querying the dict key in the function, not in the template

📊 Changes

4 files changed (+9 additions, -4 deletions)

View changed files

📝 .gitignore (+3 -0)
📝 app/routes.py (+1 -1)
📝 app/templates/error.html (+1 -1)
📝 test/test_results.py (+4 -2)

📄 Description

This (draft) PR potentially can fix Issues #1122 and (maybe) #1100.

Location of the bug found at the app/routes.py and app/templates/error.html.

Basically instead of querying the key from the translation dictionary at the template-level we should do it at the python func-level.

Please click on the links to see the details of the commits.

Also modified one of the testing script.

Open to feedback.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/benbusby/whoogle-search/pull/1126 **Author:** [@ahmad-alkadri](https://github.com/ahmad-alkadri) **Created:** 3/2/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fixes/jinja-translation-message` --- ### 📝 Commits (1) - [`7f0af09`](https://github.com/benbusby/whoogle-search/commit/7f0af097aa5724466f33f9e8c9b9ab9050a9b7b1) Fix jinja translation message by querying the dict key in the function, not in the template ### 📊 Changes **4 files changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) 📝 `app/routes.py` (+1 -1) 📝 `app/templates/error.html` (+1 -1) 📝 `test/test_results.py` (+4 -2) </details> ### 📄 Description This (draft) PR potentially can fix Issues #1122 and (maybe) #1100. Location of the bug found at the [app/routes.py](https://github.com/benbusby/whoogle-search/commit/7f0af097aa5724466f33f9e8c9b9ab9050a9b7b1#diff-f67826701212aab477be0634a23fdcd7ffdfe748b8ce35eb27b8f690d334c732) and [app/templates/error.html](https://github.com/benbusby/whoogle-search/commit/7f0af097aa5724466f33f9e8c9b9ab9050a9b7b1#diff-60a7913be4c694885dbfdfcd24057bc2b3f59f3edf0b0e01c31ecd46f40754be). Basically instead of querying the key from the `translation` dictionary at the template-level we should do it at the python func-level. Please click on the links to see the details of the commits. Also modified one of the testing script. Open to feedback. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>