mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #147] [FEATURE] Allow to see search suggestion from browser when it's the primary search engine #107
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#107
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fakeid30 on GitHub (Nov 16, 2020).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/147
Describe the feature you'd like to see added
Allow to see search suggestion from browser when it's the primary search engine like duckduckgo or google has. Not sure if it's possible.
If not possible then it's fine.
If possible but not time permitting, I would like to do it myself, any pointer on how to do it will be useful.
Thank you.
@benbusby commented on GitHub (Nov 16, 2020):
Is this what you're referring to?
If so, this is already supported. What browser are you using? Also what release of Whoogle (i.e. beta/develop vs latest/master)? The current develop branch of the project (or beta tag on Docker Hub) was recently patched with an opensearch fix that is likely relevant here if you're having issues seeing the search suggestions.
@fakeid30 commented on GitHub (Nov 17, 2020):
Yes this is exactly what I am referring to. I'm using develop (the default) branch with Firefox browser and heroku deployment. I'll wait for an update.
@benbusby or should i switch to heroku app beta ?
@benbusby commented on GitHub (Nov 17, 2020):
Yes, I just verified that the
heroku-app-betabranch works, so you can switch to that one for now.@FoxxMD commented on GitHub (Nov 18, 2020):
@benbusby Do I need to do anything to "activate" opensearch on chrome? (using beta tag on dockerhub)
@benbusby commented on GitHub (Nov 18, 2020):
@FoxxMD typically no. I did a quick test with Chrome after seeing your message and noticed the opensearch template was still getting rejected.
I just pushed
a519de90afwhich should finally resolve this issue on Chrome though. Once the beta tag on Docker Hub is updated, try with that and let me know if it works -- just be sure to remove any conflicting search engine entries in Chrome beforehand. It should automatically detect the search engine and have both search and search suggestions working properly.I manually tested the new code out with Chromium like 1000 times before pushing, so I'm fairly confident that it should work now.
@FoxxMD commented on GitHub (Nov 19, 2020):
@benbusby its working now! Thanks for all the hard work!!