[PR #969] [MERGED] Fix a bug on remove_block_titles() and remove_block_url() #1035

New issue

Closed

opened 2026-02-25 20:37:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:37:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/benbusby/whoogle-search/pull/969
Author: @xatier
Created: 3/14/2023
Status: ✅ Merged
Merged: 3/14/2023
Merged by: @benbusby

Base: main ← Head: main

📝 Commits (1)

baccc35 Fix a bug on remove_block_titles() and remove_block_url()

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 app/filter.py (+2 -2)

📄 Description

Fix the exception AttributeError: 'Filter' object has no attribute 'block_url' introduced in this commit [1].

self.block_title and self.block_url were members of the Filter object[2], but not anymore after commit [1].

This bug can be reproduced with setting WHOOGLE_CONFIG_BLOCK_URL to a non-empty string.

[1] github.com/benbusby/whoogle-search@10a15e06e1
[2] github.com/benbusby/whoogle-search@284a8102c8

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/benbusby/whoogle-search/pull/969 **Author:** [@xatier](https://github.com/xatier) **Created:** 3/14/2023 **Status:** ✅ Merged **Merged:** 3/14/2023 **Merged by:** [@benbusby](https://github.com/benbusby) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`baccc35`](https://github.com/benbusby/whoogle-search/commit/baccc350c1eb841d434e4bee58bc2492fa66f8b3) Fix a bug on remove_block_titles() and remove_block_url() ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/filter.py` (+2 -2) </details> ### 📄 Description Fix the exception `AttributeError: 'Filter' object has no attribute 'block_url'` introduced in this commit [1]. `self.block_title` and `self.block_url` were members of the Filter object[2], but not anymore after commit [1]. This bug can be reproduced with setting `WHOOGLE_CONFIG_BLOCK_URL` to a non-empty string. [1] https://github.com/benbusby/whoogle-search/commit/10a15e06e1bf6f1a22d1625950d8c221d99d6a07 [2] https://github.com/benbusby/whoogle-search/commit/284a8102c85bdc69674952bc30a6cfacfb8b01ee --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>