[PR #965] [MERGED] Add better handling of custom css #1034

Closed
opened 2026-02-25 20:37:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/benbusby/whoogle-search/pull/965
Author: @jacr13
Created: 2/24/2023
Status: Merged
Merged: 4/13/2023
Merged by: @benbusby

Base: mainHead: dev_style


📝 Commits (1)

  • a3d3024 Add better handling of custom css

📊 Changes

2 files changed (+57 additions, -8 deletions)

View changed files

📝 app/models/config.py (+55 -4)
📝 app/templates/index.html (+2 -4)

📄 Description

Fixes: #934

This pull request aims to solve exactly the problem discussed in the linked issue.

I decided to remove the "default" css from the configuration menu, as it is present in the referenced url. This is a choice, and it is straightforward to add it back. Please let me know your preference.

A possible drawback of the current approach is that it replaces the css rule by the new one, so if there are things that you want to keep from the old one, you need to specify them. This is important to keep in mind when changing variables inside :root for example.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/benbusby/whoogle-search/pull/965 **Author:** [@jacr13](https://github.com/jacr13) **Created:** 2/24/2023 **Status:** ✅ Merged **Merged:** 4/13/2023 **Merged by:** [@benbusby](https://github.com/benbusby) **Base:** `main` ← **Head:** `dev_style` --- ### 📝 Commits (1) - [`a3d3024`](https://github.com/benbusby/whoogle-search/commit/a3d30240faee5e8df0766c0b2ee07d669a1d9377) Add better handling of custom css ### 📊 Changes **2 files changed** (+57 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `app/models/config.py` (+55 -4) 📝 `app/templates/index.html` (+2 -4) </details> ### 📄 Description Fixes: #934 This pull request aims to solve exactly the problem discussed in the linked issue. I decided to remove the "default" css from the configuration menu, as it is present in the referenced url. This is a choice, and it is straightforward to add it back. Please let me know your preference. A possible drawback of the current approach is that it replaces the css rule by the new one, so if there are things that you want to keep from the old one, you need to specify them. This is important to keep in mind when changing variables inside :root for example. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 20:37:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/whoogle-search#1034
No description provided.