mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 20:25:51 +03:00
[PR #965] [MERGED] Add better handling of custom css #1034
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#1034
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/benbusby/whoogle-search/pull/965
Author: @jacr13
Created: 2/24/2023
Status: ✅ Merged
Merged: 4/13/2023
Merged by: @benbusby
Base:
main← Head:dev_style📝 Commits (1)
a3d3024Add better handling of custom css📊 Changes
2 files changed (+57 additions, -8 deletions)
View changed files
📝
app/models/config.py(+55 -4)📝
app/templates/index.html(+2 -4)📄 Description
Fixes: #934
This pull request aims to solve exactly the problem discussed in the linked issue.
I decided to remove the "default" css from the configuration menu, as it is present in the referenced url. This is a choice, and it is straightforward to add it back. Please let me know your preference.
A possible drawback of the current approach is that it replaces the css rule by the new one, so if there are things that you want to keep from the old one, you need to specify them. This is important to keep in mind when changing variables inside :root for example.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.