[PR #10] [MERGED] Handle None display names in get_contact_chats to prevent KeyError​ #24

Closed
opened 2026-03-13 15:17:37 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/absadiki/whatsapp-msgstore-viewer/pull/10
Author: @lamzib-salaheddine
Created: 4/2/2025
Status: Merged
Merged: 4/3/2025
Merged by: @absadiki

Base: mainHead: bugfix/contact-display-name-none


📝 Commits (1)

  • d372ce9 Handle None display names in get_contact_chats to prevent KeyError​

📊 Changes

1 file changed (+9 additions, -7 deletions)

View changed files

📝 Model/main_screen.py (+9 -7)

📄 Description

Resolved an issue in the get_contact_chats function where a KeyError would occur if a contact's display name was None. The function now includes a check to handle None values gracefully, ensuring that the application does not crash when encountering contacts without display names.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/absadiki/whatsapp-msgstore-viewer/pull/10 **Author:** [@lamzib-salaheddine](https://github.com/lamzib-salaheddine) **Created:** 4/2/2025 **Status:** ✅ Merged **Merged:** 4/3/2025 **Merged by:** [@absadiki](https://github.com/absadiki) **Base:** `main` ← **Head:** `bugfix/contact-display-name-none` --- ### 📝 Commits (1) - [`d372ce9`](https://github.com/absadiki/whatsapp-msgstore-viewer/commit/d372ce9b729cbd30e567cc8917e554625b92ce4f) Handle None display names in get_contact_chats to prevent KeyError​ ### 📊 Changes **1 file changed** (+9 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `Model/main_screen.py` (+9 -7) </details> ### 📄 Description Resolved an issue in the get_contact_chats function where a KeyError would occur if a contact's display name was None. The function now includes a check to handle None values gracefully, ensuring that the application does not crash when encountering contacts without display names. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-13 15:17:37 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/whatsapp-msgstore-viewer#24
No description provided.