[PR #21] [MERGED] Remove saving of contact name #91

New issue

Closed

opened 2026-02-27 04:59:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 04:59:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/guyzyl/whatsapp-contact-sync/pull/21
Author: @guyzyl
Created: 10/22/2022
Status: ✅ Merged
Merged: 10/22/2022
Merged by: @guyzyl

Base: main ← Head: remove-name

📝 Commits (1)

7d8facc Remove saving of contact name

📊 Changes

3 files changed (+0 additions, -3 deletions)

View changed files

📝 server/src/gapi.ts (+0 -1)
📝 server/src/interfaces.ts (+0 -1)
📝 server/src/whatsapp.ts (+0 -1)

📄 Description

Cases where a Google contact had a phone number but no display name caused the backend to crash.
Since the contact names weren't actually in use (and just stored), there's no harm in removing them.
This should solve the issue, and a possible fix for #20.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/guyzyl/whatsapp-contact-sync/pull/21 **Author:** [@guyzyl](https://github.com/guyzyl) **Created:** 10/22/2022 **Status:** ✅ Merged **Merged:** 10/22/2022 **Merged by:** [@guyzyl](https://github.com/guyzyl) **Base:** `main` ← **Head:** `remove-name` --- ### 📝 Commits (1) - [`7d8facc`](https://github.com/guyzyl/whatsapp-contact-sync/commit/7d8facc6fc05f9a89199b4fc9299ccf7bbc816af) Remove saving of contact name ### 📊 Changes **3 files changed** (+0 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `server/src/gapi.ts` (+0 -1) 📝 `server/src/interfaces.ts` (+0 -1) 📝 `server/src/whatsapp.ts` (+0 -1) </details> ### 📄 Description Cases where a Google contact had a phone number but no display name caused the backend to crash. Since the contact names weren't actually in use (and just stored), there's no harm in removing them. This should solve the issue, and a possible fix for #20. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>