[PR #14] [MERGED] Fix home button bug #85

New issue

Closed

opened 2026-02-27 04:59:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 04:59:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/guyzyl/whatsapp-contact-sync/pull/14
Author: @guyzyl
Created: 8/22/2022
Status: ✅ Merged
Merged: 8/22/2022
Merged by: @guyzyl

Base: main ← Head: fix-home-button-bug

📝 Commits (3)

0ae2c64 Create deferred.ts
114fe3e Update ws.ts
eef2323 Update Home.vue

📊 Changes

3 files changed (+56 additions, -4 deletions)

View changed files

➕ web/src/deferred.ts (+47 -0)
📝 web/src/pages/Home.vue (+6 -4)
📝 web/src/services/ws.ts (+3 -0)

📄 Description

Fixed another bug where the WS is created after the home page is created, causing the imported WS by the home page to be undefined.
This is now fixed by creating a Deferred Promise that is resolved once the WS is ready and is imported by the home page.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/guyzyl/whatsapp-contact-sync/pull/14 **Author:** [@guyzyl](https://github.com/guyzyl) **Created:** 8/22/2022 **Status:** ✅ Merged **Merged:** 8/22/2022 **Merged by:** [@guyzyl](https://github.com/guyzyl) **Base:** `main` ← **Head:** `fix-home-button-bug` --- ### 📝 Commits (3) - [`0ae2c64`](https://github.com/guyzyl/whatsapp-contact-sync/commit/0ae2c64b719da713ce95772f056533487859bccc) Create deferred.ts - [`114fe3e`](https://github.com/guyzyl/whatsapp-contact-sync/commit/114fe3edda6e0029614a0452f847779429071945) Update ws.ts - [`eef2323`](https://github.com/guyzyl/whatsapp-contact-sync/commit/eef2323922bfaa87dfbe9d762a584a81e431324c) Update Home.vue ### 📊 Changes **3 files changed** (+56 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `web/src/deferred.ts` (+47 -0) 📝 `web/src/pages/Home.vue` (+6 -4) 📝 `web/src/services/ws.ts` (+3 -0) </details> ### 📄 Description Fixed another bug where the WS is created after the home page is created, causing the imported WS by the home page to be `undefined`. This is now fixed by creating a `Deferred` `Promise` that is resolved once the WS is ready and is imported by the home page. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>