[PR #102] [MERGED] Fix TypeScript Error in src/main.ts #149

New issue

Closed

opened 2026-02-27 04:59:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 04:59:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/guyzyl/whatsapp-contact-sync/pull/102
Author: @Repsay
Created: 7/2/2023
Status: ✅ Merged
Merged: 7/2/2023
Merged by: @guyzyl

Base: main ← Head: fix-build-error

📝 Commits (1)

2be23d7 Fix build error in main.ts

📊 Changes

1 file changed (+11 additions, -3 deletions)

View changed files

📝 web/src/main.ts (+11 -3)

📄 Description

This PR resolves the TypeScript error encountered during the Docker build process as reported in issue #101.

The issue was due to a type mismatch between the pageTrackerTemplate function and the PluginOptions type in the src/main.ts file. The pageTrackerTemplate function was expecting no arguments and a return type of PageView, but was provided a function that takes a RouteLocationNormalized argument and returns an object with page_title and page_path.

I have corrected this mismatch, and the Docker build process now completes successfully. Please review the changes and let me know if there are any concerns.

Fixes #101.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/guyzyl/whatsapp-contact-sync/pull/102 **Author:** [@Repsay](https://github.com/Repsay) **Created:** 7/2/2023 **Status:** ✅ Merged **Merged:** 7/2/2023 **Merged by:** [@guyzyl](https://github.com/guyzyl) **Base:** `main` ← **Head:** `fix-build-error` --- ### 📝 Commits (1) - [`2be23d7`](https://github.com/guyzyl/whatsapp-contact-sync/commit/2be23d76dd00abfa87db2c795115fa461dd5b00f) Fix build error in main.ts ### 📊 Changes **1 file changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `web/src/main.ts` (+11 -3) </details> ### 📄 Description This PR resolves the TypeScript error encountered during the Docker build process as reported in issue #101. The issue was due to a type mismatch between the `pageTrackerTemplate` function and the `PluginOptions` type in the `src/main.ts` file. The `pageTrackerTemplate` function was expecting no arguments and a return type of `PageView`, but was provided a function that takes a `RouteLocationNormalized` argument and returns an object with `page_title` and `page_path`. I have corrected this mismatch, and the Docker build process now completes successfully. Please review the changes and let me know if there are any concerns. Fixes #101. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>