[PR #608] [MERGED] Some improvements on Console / HDD disk device #692

New issue

Closed

opened 2026-02-27 16:40:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:40:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/608
Author: @brenard
Created: 4/1/2016
Status: ✅ Merged
Merged: 5/8/2016
Merged by: @retspen

Base: master ← Head: master

📝 Commits (7)

df48bfa Unified VNC/SPICE console interfaces with bootstrap
81a42af Fix console local socket access on CONN_SOCKET host
385cd33 Merge remote-tracking branch 'upstream/master'
0e0bae2 Add possibility to configure HDD cache mode during instance creation
8517ba9 Retreive all RBD hosts (and their port if defined) from pool definition during instance creation
e94d0c3 Fix pep8 error
1f9d6e1 Fix pep8 error (bis)

📊 Changes

8 files changed (+443 additions, -406 deletions)

View changed files

📝 console/webvirtmgr-console (+1 -1)
📝 create/forms.py (+1 -0)
📝 create/views.py (+6 -1)
➕ templates/console-base.html (+124 -0)
📝 templates/console-spice.html (+174 -314)
📝 templates/console-vnc.html (+77 -79)
📝 templates/create.html (+22 -0)
📝 vrtManager/create.py (+38 -11)

📄 Description

I made some improvements during my recent integrations of WebVirtMgr and I forget to make a pull request. So, this pull request address different topics :

I unified VNC and Spice console interfaces with bootstrap. In the same goal, I add some Crtl+Alt+FX send keys features in VNC console (already exists in Spice console)
I fix console access on instance running on hypervisor access thought local UNIX socket
I add possibility to define HDD cache mode during instance creation
I improve RBD disk device definition on instance creation :
- All RBD monitor hosts is retrieve from RBD pool definition, not only the first
- RBD port of monitor hosts is not hard coded but retrieve from pool definition

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/608 **Author:** [@brenard](https://github.com/brenard) **Created:** 4/1/2016 **Status:** ✅ Merged **Merged:** 5/8/2016 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`df48bfa`](https://github.com/retspen/webvirtmgr/commit/df48bfaf4c0c67ceda083b319f38f70c29ab589c) Unified VNC/SPICE console interfaces with bootstrap - [`81a42af`](https://github.com/retspen/webvirtmgr/commit/81a42afda776731f22dd2a61e28b5a408a6419c4) Fix console local socket access on CONN_SOCKET host - [`385cd33`](https://github.com/retspen/webvirtmgr/commit/385cd3320fa2c3cd617e10e054a1efe0ce08cf8b) Merge remote-tracking branch 'upstream/master' - [`0e0bae2`](https://github.com/retspen/webvirtmgr/commit/0e0bae2c1f18089403dd87fe44c00f7343f31f16) Add possibility to configure HDD cache mode during instance creation - [`8517ba9`](https://github.com/retspen/webvirtmgr/commit/8517ba95d0e29b4ec4cd3328d437bb4ba8e7551c) Retreive all RBD hosts (and their port if defined) from pool definition during instance creation - [`e94d0c3`](https://github.com/retspen/webvirtmgr/commit/e94d0c36b9716b9af05029548fb68ca1e0c5b16f) Fix pep8 error - [`1f9d6e1`](https://github.com/retspen/webvirtmgr/commit/1f9d6e1e491ea46ec9936046831a57ba6dd624ff) Fix pep8 error (bis) ### 📊 Changes **8 files changed** (+443 additions, -406 deletions) <details> <summary>View changed files</summary> 📝 `console/webvirtmgr-console` (+1 -1) 📝 `create/forms.py` (+1 -0) 📝 `create/views.py` (+6 -1) ➕ `templates/console-base.html` (+124 -0) 📝 `templates/console-spice.html` (+174 -314) 📝 `templates/console-vnc.html` (+77 -79) 📝 `templates/create.html` (+22 -0) 📝 `vrtManager/create.py` (+38 -11) </details> ### 📄 Description I made some improvements during my recent integrations of WebVirtMgr and I forget to make a pull request. So, this pull request address different topics : - I unified VNC and Spice console interfaces with bootstrap. In the same goal, I add some Crtl+Alt+FX send keys features in VNC console (already exists in Spice console) - I fix console access on instance running on hypervisor access thought local UNIX socket - I add possibility to define HDD cache mode during instance creation - I improve RBD disk device definition on instance creation : - All RBD monitor hosts is retrieve from RBD pool definition, not only the first - RBD port of monitor hosts is not hard coded but retrieve from pool definition --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>