[PR #584] [MERGED] Properly parse the capabilities XML to confirm KVM support #686

New issue

Closed

opened 2026-02-27 16:40:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:40:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/584
Author: @mattface
Created: 11/2/2015
Status: ✅ Merged
Merged: 11/27/2015
Merged by: @retspen

Base: master ← Head: master

📝 Commits (2)

202b73b Properly parse the capabilities XML to confirm KVM support
df3c5c1 Fixup an un-needed import

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 vrtManager/util.py (+2 -3)

📄 Description

I was using webvirtmgr on an old piece of hardware that didnt have KVM support, but the word "kvm" appeared in the capabilities XML so I was unable to create a new instance as this function was determining I had KVM available.

I've used one of the helper methods in utils to parse the XML for the domain/type section instead. This works on my non-KVM box and my newer KVM-capable machine, though it could do with wider testing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/584 **Author:** [@mattface](https://github.com/mattface) **Created:** 11/2/2015 **Status:** ✅ Merged **Merged:** 11/27/2015 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`202b73b`](https://github.com/retspen/webvirtmgr/commit/202b73be51cc99c6cbfcf0c3bb1c63985bd0fc38) Properly parse the capabilities XML to confirm KVM support - [`df3c5c1`](https://github.com/retspen/webvirtmgr/commit/df3c5c1ec19d55e29e5581f29daae875724f9421) Fixup an un-needed import ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `vrtManager/util.py` (+2 -3) </details> ### 📄 Description I was using webvirtmgr on an old piece of hardware that didnt have KVM support, but the word "kvm" appeared in the capabilities XML so I was unable to create a new instance as this function was determining I had KVM available. I've used one of the helper methods in utils to parse the XML for the domain/type section instead. This works on my non-KVM box and my newer KVM-capable machine, though it could do with wider testing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>