[PR #545] [MERGED] Some fix and improvements on console access #684

New issue

Closed

opened 2026-02-27 16:40:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:40:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/545
Author: @brenard
Created: 4/22/2015
Status: ✅ Merged
Merged: 4/23/2015
Merged by: @retspen

Base: master ← Head: master

📝 Commits (10+)

86c6a2f Add possibility to pass options to webvirtmgr-console daemon
17105d8 Check and warn if token cookie is not found
e6b35fe Add send-keys menu to Spice console
88247e8 Add fullscreen button on VNC/Spice console page
9f99677 Fix Spice console menu style
fd5b8b5 Improve get_console_listen_addr() method
e11a464 Raise on get_connection_infos() exception and add connection infos debug message
67c2846 Fix connhost / connport detection (Thanks @tboulogne on #498)
b5a339f Rename webvirtmgr-novnc in webvirtmgr-console in initd/deploy scripts
83b0089 Fix SPICE console template to encrypt websocket connection if page is access over HTTPS

📊 Changes

12 files changed (+247 additions, -45 deletions)

View changed files

📝 conf/conf.d/webvirtmgr-console (+1 -1)
📝 conf/initd/webvirtmgr-console-arch (+2 -2)
📝 conf/initd/webvirtmgr-console-gentoo (+1 -1)
📝 conf/initd/webvirtmgr-console-redhat (+1 -1)
📝 conf/initd/webvirtmgr-console-suse (+2 -2)
📝 conf/initd/webvirtmgr-console-ubuntu (+1 -1)
📝 console/webvirtmgr-console (+77 -24)
📝 deploy/fabric/utils.py (+8 -8)
📝 deploy/rpmbuild/webvirtmgr.spec (+1 -1)
📝 templates/console-spice.html (+127 -2)
📝 templates/console-vnc.html (+21 -2)
📝 vrtManager/instance.py (+5 -0)

📄 Description

Hi,

During last months, I made some fix and improvement on console access feature. All is compiled on this push request.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/545 **Author:** [@brenard](https://github.com/brenard) **Created:** 4/22/2015 **Status:** ✅ Merged **Merged:** 4/23/2015 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`86c6a2f`](https://github.com/retspen/webvirtmgr/commit/86c6a2fb96c2b136ed543b92a3914e81f56e158a) Add possibility to pass options to webvirtmgr-console daemon - [`17105d8`](https://github.com/retspen/webvirtmgr/commit/17105d83378e97d2649a9ff9d65779340a56153f) Check and warn if token cookie is not found - [`e6b35fe`](https://github.com/retspen/webvirtmgr/commit/e6b35fed253a9bb9030d316536af4986dc26b4bb) Add send-keys menu to Spice console - [`88247e8`](https://github.com/retspen/webvirtmgr/commit/88247e820632f9a115b578adee334ea95439d00c) Add fullscreen button on VNC/Spice console page - [`9f99677`](https://github.com/retspen/webvirtmgr/commit/9f9967706b651b457de2ae803a8a8498e82dc053) Fix Spice console menu style - [`fd5b8b5`](https://github.com/retspen/webvirtmgr/commit/fd5b8b58d58f828f62438ebad17e197fd279a8dd) Improve get_console_listen_addr() method - [`e11a464`](https://github.com/retspen/webvirtmgr/commit/e11a4646e49490af79321a56462ea7f35b5d6dbe) Raise on get_connection_infos() exception and add connection infos debug message - [`67c2846`](https://github.com/retspen/webvirtmgr/commit/67c2846dfd04348ecbf76212f1ad43e10f9e6725) Fix connhost / connport detection (Thanks @tboulogne on #498) - [`b5a339f`](https://github.com/retspen/webvirtmgr/commit/b5a339f3297a902c6b951c896091ed8f47c35359) Rename webvirtmgr-novnc in webvirtmgr-console in initd/deploy scripts - [`83b0089`](https://github.com/retspen/webvirtmgr/commit/83b0089624daed1000d6170b5fdcb9d4864980fd) Fix SPICE console template to encrypt websocket connection if page is access over HTTPS ### 📊 Changes **12 files changed** (+247 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `conf/conf.d/webvirtmgr-console` (+1 -1) 📝 `conf/initd/webvirtmgr-console-arch` (+2 -2) 📝 `conf/initd/webvirtmgr-console-gentoo` (+1 -1) 📝 `conf/initd/webvirtmgr-console-redhat` (+1 -1) 📝 `conf/initd/webvirtmgr-console-suse` (+2 -2) 📝 `conf/initd/webvirtmgr-console-ubuntu` (+1 -1) 📝 `console/webvirtmgr-console` (+77 -24) 📝 `deploy/fabric/utils.py` (+8 -8) 📝 `deploy/rpmbuild/webvirtmgr.spec` (+1 -1) 📝 `templates/console-spice.html` (+127 -2) 📝 `templates/console-vnc.html` (+21 -2) 📝 `vrtManager/instance.py` (+5 -0) </details> ### 📄 Description Hi, During last months, I made some fix and improvement on console access feature. All is compiled on this push request. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>