[PR #523] [MERGED] Fix LVM device validation #678

New issue

Closed

opened 2026-02-27 16:40:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:40:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/523
Author: @danhper
Created: 3/16/2015
Status: ✅ Merged
Merged: 3/16/2015
Merged by: @retspen

Base: master ← Head: master

📝 Commits (2)

1da815a Fix pep8 failure.
525c9df Fix too strict validation for LVM device.

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 storages/forms.py (+1 -1)
📝 templates/storages.html (+1 -1)
📝 vrtManager/instance.py (+1 -1)

📄 Description

Hi,

When using disks in a RAID, disks name such as /dev/mapper/isw_dhbbdjjcfb_system3,
which failed validation while being correct. I made a small change to the validation regex to allow underscores.

I also fixed the file making the build fail due to pep8 warning.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/523 **Author:** [@danhper](https://github.com/danhper) **Created:** 3/16/2015 **Status:** ✅ Merged **Merged:** 3/16/2015 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`1da815a`](https://github.com/retspen/webvirtmgr/commit/1da815afbde0df64b01aab1e2dd16d3194d3bf77) Fix pep8 failure. - [`525c9df`](https://github.com/retspen/webvirtmgr/commit/525c9dfb6bbb5ad99f6946b3e19c05bff09254ee) Fix too strict validation for LVM device. ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `storages/forms.py` (+1 -1) 📝 `templates/storages.html` (+1 -1) 📝 `vrtManager/instance.py` (+1 -1) </details> ### 📄 Description Hi, When using disks in a RAID, disks name such as `/dev/mapper/isw_dhbbdjjcfb_system3`, which failed validation while being correct. I made a small change to the validation regex to allow underscores. I also fixed the file making the build fail due to pep8 warning. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>