[PR #488] [MERGED] Some fixes and improvements for my use cases #674

New issue

Closed

opened 2026-02-27 16:40:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:40:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/488
Author: @brenard
Created: 1/15/2015
Status: ✅ Merged
Merged: 1/23/2015
Merged by: @retspen

Base: master ← Head: master

📝 Commits (10+)

731bc33 Add WS_PUBLIC_HOST variable to permit to define WS public host address
4bbef4c Check disk's image attribute before accessing in show_clone_disk()
5c7b890 Check graphic device exist before define password and show error message if not exist
1cd1a58 Adapt Shutdown tab message and title when the instance is shutoff
955e279 Add support for spice console
c3d641b Fix typo
928315e Display shutdown/suspend/save tabs only when is accessibled
fc0258b Add support of SSH tunneling to access instance's console
3e08c1c Add support for console's socket on localhost
1391692 Fix cookies access in instusage

📊 Changes

44 files changed (+11285 additions, -146 deletions)

View changed files

➕ console/tunnel.py (+145 -0)
📝 console/views.py (+17 -8)
📝 console/webvirtmgr-console (+61 -18)
📝 instance/views.py (+35 -31)
➕ templates/console-spice.html (+208 -0)
📝 templates/console-vnc.html (+1 -1)
📝 templates/instance.html (+95 -57)
📝 templates/instances.html (+7 -7)
📝 vrtManager/create.py (+4 -2)
📝 vrtManager/instance.py (+63 -22)
📝 webvirtmgr/settings.py (+7 -0)
➕ webvirtmgr/static/js/spice-html5/atKeynames.js (+183 -0)
➕ webvirtmgr/static/js/spice-html5/bitmap.js (+51 -0)
➕ webvirtmgr/static/js/spice-html5/cursor.js (+110 -0)
➕ webvirtmgr/static/js/spice-html5/display.js (+823 -0)
➕ webvirtmgr/static/js/spice-html5/enums.js (+348 -0)
➕ webvirtmgr/static/js/spice-html5/filexfer.js (+88 -0)
➕ webvirtmgr/static/js/spice-html5/inputs.js (+280 -0)
➕ webvirtmgr/static/js/spice-html5/jsbn.js (+589 -0)
➕ webvirtmgr/static/js/spice-html5/lz.js (+166 -0)

...and 24 more files

📄 Description

Hello,

I upgrade my webvirtmgr installation and I discover some bugs with my use cases :

I using reverse proxy behind webvirtmgr and it's causing error in WS_HOST address detection. I add for that an variable WS_PUBLIC_HOST to leave possibility to self define this address. If this variable is leave to None, the address will be auto-detect as usual.
One of my instance causing libvirt storageVolLookupByPath returning None one is disk. This causing exception during displaying instance view. I add a check for that case.
On instance that does not have graphic device, setting password causing exception. I add a check and an error message for that case.
On instance view, I adapt Shutdown tab message and title when instance is shutoff. Currently the application display Shutdown messages, just the button is adapted.

Thank's for this great shoftware !

Benjamin

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/488 **Author:** [@brenard](https://github.com/brenard) **Created:** 1/15/2015 **Status:** ✅ Merged **Merged:** 1/23/2015 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`731bc33`](https://github.com/retspen/webvirtmgr/commit/731bc3304bb319656a7c1f90d9d858be736a06f5) Add WS_PUBLIC_HOST variable to permit to define WS public host address - [`4bbef4c`](https://github.com/retspen/webvirtmgr/commit/4bbef4c2cc47e1034236f34c9cbda408be6358b5) Check disk's image attribute before accessing in show_clone_disk() - [`5c7b890`](https://github.com/retspen/webvirtmgr/commit/5c7b89033eae145c9ae56b476d6d1193d92176e9) Check graphic device exist before define password and show error message if not exist - [`1cd1a58`](https://github.com/retspen/webvirtmgr/commit/1cd1a58a12cec7daeb19bd0c277d7e43da787413) Adapt Shutdown tab message and title when the instance is shutoff - [`955e279`](https://github.com/retspen/webvirtmgr/commit/955e27909dfdc75a57c40cfb16d97bc19684d412) Add support for spice console - [`c3d641b`](https://github.com/retspen/webvirtmgr/commit/c3d641bbf66a528e6f3add94a7ed8bbc7d380774) Fix typo - [`928315e`](https://github.com/retspen/webvirtmgr/commit/928315ee5a8e79b5d00c24f22407d8bced355153) Display shutdown/suspend/save tabs only when is accessibled - [`fc0258b`](https://github.com/retspen/webvirtmgr/commit/fc0258bb1feb4ccc6aaa328492f3e810e90b7031) Add support of SSH tunneling to access instance's console - [`3e08c1c`](https://github.com/retspen/webvirtmgr/commit/3e08c1ca7cbe0aff73377adfdc907262bb2774fc) Add support for console's socket on localhost - [`1391692`](https://github.com/retspen/webvirtmgr/commit/1391692162eb42293eaa41f809800049578d3ecc) Fix cookies access in instusage ### 📊 Changes **44 files changed** (+11285 additions, -146 deletions) <details> <summary>View changed files</summary> ➕ `console/tunnel.py` (+145 -0) 📝 `console/views.py` (+17 -8) 📝 `console/webvirtmgr-console` (+61 -18) 📝 `instance/views.py` (+35 -31) ➕ `templates/console-spice.html` (+208 -0) 📝 `templates/console-vnc.html` (+1 -1) 📝 `templates/instance.html` (+95 -57) 📝 `templates/instances.html` (+7 -7) 📝 `vrtManager/create.py` (+4 -2) 📝 `vrtManager/instance.py` (+63 -22) 📝 `webvirtmgr/settings.py` (+7 -0) ➕ `webvirtmgr/static/js/spice-html5/atKeynames.js` (+183 -0) ➕ `webvirtmgr/static/js/spice-html5/bitmap.js` (+51 -0) ➕ `webvirtmgr/static/js/spice-html5/cursor.js` (+110 -0) ➕ `webvirtmgr/static/js/spice-html5/display.js` (+823 -0) ➕ `webvirtmgr/static/js/spice-html5/enums.js` (+348 -0) ➕ `webvirtmgr/static/js/spice-html5/filexfer.js` (+88 -0) ➕ `webvirtmgr/static/js/spice-html5/inputs.js` (+280 -0) ➕ `webvirtmgr/static/js/spice-html5/jsbn.js` (+589 -0) ➕ `webvirtmgr/static/js/spice-html5/lz.js` (+166 -0) _...and 24 more files_ </details> ### 📄 Description Hello, I upgrade my webvirtmgr installation and I discover some bugs with my use cases : - I using reverse proxy behind webvirtmgr and it's causing error in WS_HOST address detection. I add for that an variable WS_PUBLIC_HOST to leave possibility to self define this address. If this variable is leave to None, the address will be auto-detect as usual. - One of my instance causing libvirt storageVolLookupByPath returning None one is disk. This causing exception during displaying instance view. I add a check for that case. - On instance that does not have graphic device, setting password causing exception. I add a check and an error message for that case. - On instance view, I adapt Shutdown tab message and title when instance is shutoff. Currently the application display Shutdown messages, just the button is adapted. Thank's for this great shoftware ! Benjamin --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>