[PR #403] [MERGED] Responsive design #646

New issue

Closed

opened 2026-02-27 16:40:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:40:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/403
Author: @michelkaeser
Created: 8/30/2014
Status: ✅ Merged
Merged: 9/1/2014
Merged by: @retspen

Base: master ← Head: rwd

📝 Commits (5)

46a1df0 Responsive design
51f4a91 fix table on create page
2a4dfa2 check if returned value is an array (fixes NonType object is unsubscriptable)
8e8f2b3 should fix CI (pep8)...
caa19ac Instances table should not be cropped cause of the buttons

📊 Changes

28 files changed (+1094 additions, -1031 deletions)

View changed files

📝 networks/views.py (+3 -1)
📝 templates/404.html (+2 -2)
📝 templates/500.html (+2 -2)
📝 templates/base.html (+10 -7)
📝 templates/base_auth.html (+7 -7)
📝 templates/console.html (+1 -0)
📝 templates/create.html (+120 -116)
📝 templates/hostdetail.html (+41 -43)
📝 templates/infrastructure.html (+49 -47)
📝 templates/instance.html (+19 -16)
📝 templates/instances.html (+114 -111)
📝 templates/interface.html (+50 -48)
📝 templates/interfaces.html (+15 -10)
📝 templates/login.html (+17 -13)
📝 templates/logout.html (+7 -3)
📝 templates/network.html (+98 -95)
📝 templates/networks.html (+16 -11)
📝 templates/secrets.html (+4 -4)
📝 templates/servers.html (+219 -214)
📝 templates/sidebar.html (+35 -31)

...and 8 more files

📄 Description

I have made the design fully mobile & tablet friendly. Hope you are able to merge that :)

Few things that might need discussion:

I have replaced the local BS files with CND URLs
The charts are not responsive (width)
I was unable to access the DHCP array by index from within the template so I made two helper methods

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/403 **Author:** [@michelkaeser](https://github.com/michelkaeser) **Created:** 8/30/2014 **Status:** ✅ Merged **Merged:** 9/1/2014 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `rwd` --- ### 📝 Commits (5) - [`46a1df0`](https://github.com/retspen/webvirtmgr/commit/46a1df05d3b0d0836e9cfd8a711511ee0ab3ff28) Responsive design - [`51f4a91`](https://github.com/retspen/webvirtmgr/commit/51f4a913a5b308ff683e9e6d7ce6419772828af4) fix table on create page - [`2a4dfa2`](https://github.com/retspen/webvirtmgr/commit/2a4dfa2a4f3edcb50da732fbf0dfd08bd76d8923) check if returned value is an array (fixes NonType object is unsubscriptable) - [`8e8f2b3`](https://github.com/retspen/webvirtmgr/commit/8e8f2b39a4e85b972bf020184db6de22cc5d82fd) should fix CI (pep8)... - [`caa19ac`](https://github.com/retspen/webvirtmgr/commit/caa19ace34b65fe44002f2790e672acee4a8d0ef) Instances table should not be cropped cause of the buttons ### 📊 Changes **28 files changed** (+1094 additions, -1031 deletions) <details> <summary>View changed files</summary> 📝 `networks/views.py` (+3 -1) 📝 `templates/404.html` (+2 -2) 📝 `templates/500.html` (+2 -2) 📝 `templates/base.html` (+10 -7) 📝 `templates/base_auth.html` (+7 -7) 📝 `templates/console.html` (+1 -0) 📝 `templates/create.html` (+120 -116) 📝 `templates/hostdetail.html` (+41 -43) 📝 `templates/infrastructure.html` (+49 -47) 📝 `templates/instance.html` (+19 -16) 📝 `templates/instances.html` (+114 -111) 📝 `templates/interface.html` (+50 -48) 📝 `templates/interfaces.html` (+15 -10) 📝 `templates/login.html` (+17 -13) 📝 `templates/logout.html` (+7 -3) 📝 `templates/network.html` (+98 -95) 📝 `templates/networks.html` (+16 -11) 📝 `templates/secrets.html` (+4 -4) 📝 `templates/servers.html` (+219 -214) 📝 `templates/sidebar.html` (+35 -31) _...and 8 more files_ </details> ### 📄 Description I have made the design fully mobile & tablet friendly. Hope you are able to merge that :) Few things that might need discussion: - I have replaced the local BS files with CND URLs - The charts are not responsive (width) - I was unable to access the DHCP array by index from within the template so I made two helper methods --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>