[PR #351] [MERGED] Merged webvirtmgr-novnc-new into a smarter webvirtmgr-novnc #636

New issue

Closed

opened 2026-02-27 16:39:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:39:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/351
Author: @casell
Created: 6/27/2014
Status: ✅ Merged
Merged: 7/3/2014
Merged by: @retspen

Base: master ← Head: novncproxymerge

📝 Commits (2)

ef9feb8 Merged webvirtmgr-novnc-new into a smarter webvirtmgr-novnc
25d0542 Added help message in case no websockify implementation can be found

📊 Changes

2 files changed (+96 additions, -123 deletions)

View changed files

📝 console/webvirtmgr-novnc (+96 -32)
➖ console/webvirtmgr-novnc-new (+0 -91)

📄 Description

Further changes to the proxy starter to avoid the need of choose the right script to launch.

With this commit the user just needs to launch the webvirtmgr-novnc script and it will take care of choosing the right way to setup the server (either with novnc, websockify < 0.6.0 or websockify == 0.6.0)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/351 **Author:** [@casell](https://github.com/casell) **Created:** 6/27/2014 **Status:** ✅ Merged **Merged:** 7/3/2014 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `novncproxymerge` --- ### 📝 Commits (2) - [`ef9feb8`](https://github.com/retspen/webvirtmgr/commit/ef9feb846231e7aaf47535d60b48ea85b622bcb5) Merged webvirtmgr-novnc-new into a smarter webvirtmgr-novnc - [`25d0542`](https://github.com/retspen/webvirtmgr/commit/25d05425c0b9ce9909f0d7362805cef8f5f21332) Added help message in case no websockify implementation can be found ### 📊 Changes **2 files changed** (+96 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `console/webvirtmgr-novnc` (+96 -32) ➖ `console/webvirtmgr-novnc-new` (+0 -91) </details> ### 📄 Description Further changes to the proxy starter to avoid the need of choose the right script to launch. With this commit the user just needs to launch the webvirtmgr-novnc script and it will take care of choosing the right way to setup the server (either with novnc, websockify < 0.6.0 or websockify == 0.6.0) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>