[PR #346] [MERGED] New novnc websockify wrapper #633

New issue

Closed

opened 2026-02-27 16:39:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:39:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/346
Author: @casell
Created: 6/25/2014
Status: ✅ Merged
Merged: 6/27/2014
Merged by: @retspen

Base: master ← Head: websockify

📝 Commits (1)

67b2901 New novnc wrapper

📊 Changes

1 file changed (+91 additions, -0 deletions)

View changed files

➕ console/webvirtmgr-novnc-new (+91 -0)

📄 Description

Added novnc proxy supporting new websockify versions

The websockify library starting from this commit:

github.com/kanaka/websockify@7b3dd8a6f5

separates WebSocketProxy from the handler class

The NovaWebSocketProxy class defined in console/webvirtmgr-novnc inherit from WebSocketProxy and still seems to work but its new_client method never gets called.

This commit adds a new script that can be used with the new websockify library.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/346 **Author:** [@casell](https://github.com/casell) **Created:** 6/25/2014 **Status:** ✅ Merged **Merged:** 6/27/2014 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `websockify` --- ### 📝 Commits (1) - [`67b2901`](https://github.com/retspen/webvirtmgr/commit/67b2901e5ae4ef046867f7115dfd850ea0beb801) New novnc wrapper ### 📊 Changes **1 file changed** (+91 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `console/webvirtmgr-novnc-new` (+91 -0) </details> ### 📄 Description Added novnc proxy supporting new websockify versions The websockify library starting from this commit: https://github.com/kanaka/websockify/commit/7b3dd8a6f5ef26dbfd6c34a91600ea1613aefaa2 separates WebSocketProxy from the handler class The `NovaWebSocketProxy` class defined in console/webvirtmgr-novnc inherit from `WebSocketProxy` and still seems to work but its `new_client` method never gets called. This commit adds a new script that can be used with the new websockify library. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>