[PR #333] [MERGED] Skip over offline storage devices when mounting isos #626

New issue

Closed

opened 2026-02-27 16:39:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:39:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/333
Author: @ibuclaw
Created: 6/10/2014
Status: ✅ Merged
Merged: 6/12/2014
Merged by: @retspen

Base: master ← Head: mountiso

📝 Commits (1)

042525e Skip over offline storage devices when mounting isos

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 vrtManager/instance.py (+4 -3)

📄 Description

When mounting ISOs via Instance > Settings > Media, was getting the following error that is telling me about an iSCSI pool that is not related to the VM I was changing:

Requested operation is not valid: storage pool vmpool-iscsi' is not active`

Tracked it down to the following area this pull request fixes, which tells mount_iso to skip over offlined storaged pools.

To reproduce, create a pool against a host, then stop it. Then try and attach an ISO to a VM. If you look at get_iso_media which retrieves the list of ISOs to available to mount, it does the same thing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/333 **Author:** [@ibuclaw](https://github.com/ibuclaw) **Created:** 6/10/2014 **Status:** ✅ Merged **Merged:** 6/12/2014 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `mountiso` --- ### 📝 Commits (1) - [`042525e`](https://github.com/retspen/webvirtmgr/commit/042525ea7760779ce8f100333bb38232c1a5d649) Skip over offline storage devices when mounting isos ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `vrtManager/instance.py` (+4 -3) </details> ### 📄 Description When mounting ISOs via Instance > Settings > Media, was getting the following error that is telling me about an iSCSI pool that is not related to the VM I was changing: `Requested operation is not valid: storage pool `vmpool-iscsi' is not active` Tracked it down to the following area this pull request fixes, which tells `mount_iso` to skip over offlined storaged pools. To reproduce, create a pool against a host, then stop it. Then try and attach an ISO to a VM. If you look at `get_iso_media` which retrieves the list of ISOs to available to mount, it does the same thing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>