[PR #305] [MERGED] Allow the user to specify target disk drive filenames when cloning instances. #613

New issue

Closed

opened 2026-02-27 16:39:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:39:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/305
Author: @cambrant
Created: 5/13/2014
Status: ✅ Merged
Merged: 5/14/2014
Merged by: @retspen

Base: master ← Head: master

📝 Commits (2)

5b4d9b1 Allow the user to specify target filenames of cloned disk drives.
ccde370 Fixed some whitespace errors found by pep8.

📊 Changes

3 files changed (+45 additions, -44 deletions)

View changed files

📝 instance/views.py (+9 -3)
📝 templates/instance.html (+2 -2)
📝 vrtManager/instance.py (+34 -39)

📄 Description

Hi,

I often clone instances from "template" VMs and would like to have more control of the image names to be able to tell them apart. When cloning, for example, "debian-template" with the disk volume "debian-template.img", the target file name is always "debian-template-clone.img" today. I'd like to be able to choose the file name of the new image file, and not just the instance name, if that makes sense.

This patch makes the target file names editable, and generates the new XML file with that in mind. The file names still default to the current standard, like "debian-template-clone.img". It works fine on my system which is running qemu, even with more than one storage device. I'd still recommend you to test this a bit first before committing it to master. I hope it's a step in the right direction towards more complete user control.

I might add: comments on this would be fine as well. I can give it another go if there are any problems with this code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/305 **Author:** [@cambrant](https://github.com/cambrant) **Created:** 5/13/2014 **Status:** ✅ Merged **Merged:** 5/14/2014 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`5b4d9b1`](https://github.com/retspen/webvirtmgr/commit/5b4d9b11a97277b5932621e2bee7c6aef616d21a) Allow the user to specify target filenames of cloned disk drives. - [`ccde370`](https://github.com/retspen/webvirtmgr/commit/ccde3706bae48a34a57d650ba0c2490b1a427df5) Fixed some whitespace errors found by pep8. ### 📊 Changes **3 files changed** (+45 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `instance/views.py` (+9 -3) 📝 `templates/instance.html` (+2 -2) 📝 `vrtManager/instance.py` (+34 -39) </details> ### 📄 Description Hi, I often clone instances from "template" VMs and would like to have more control of the image names to be able to tell them apart. When cloning, for example, "debian-template" with the disk volume "debian-template.img", the target file name is always "debian-template-clone.img" today. I'd like to be able to choose the file name of the new image file, and not just the instance name, if that makes sense. This patch makes the target file names editable, and generates the new XML file with that in mind. The file names still default to the current standard, like "debian-template-clone.img". It works fine on my system which is running qemu, even with more than one storage device. I'd still recommend you to test this a bit first before committing it to master. I hope it's a step in the right direction towards more complete user control. I might add: comments on this would be fine as well. I can give it another go if there are any problems with this code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>