[PR #293] [MERGED] Add VNC keymap support and allow password clear #606

New issue

Closed

opened 2026-02-27 16:39:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:39:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/293
Author: @daniel-k
Created: 4/25/2014
Status: ✅ Merged
Merged: 4/26/2014
Merged by: @retspen

Base: master ← Head: master

📝 Commits (3)

dc40cba add vnc password clear
a6c3d0a add vnc keymap setting, improve set_vnc_passwd and set_vnc_keymap
de1931f fix clear passwd/keymap when not set

📊 Changes

4 files changed (+113 additions, -11 deletions)

View changed files

📝 instance/views.py (+15 -2)
📝 templates/instance.html (+64 -2)
📝 vrtManager/instance.py (+28 -7)
📝 webvirtmgr/settings.py (+6 -0)

📄 Description

Hello,

I just added support for setting vnc keymap (as also requested by #140) and added the functionality to clear the vnc password. No real big changes, just an improvement in vrtManager/instance.py:wvmInstance.set_vnc_passwd. The old implementation used regex to manipulate the xml, I now use ElementTree, this is less messy and was needed so that you can set and reset password and keymap independently (other setting was deleted every time).

Hope you like it, this is my first pull request on github :)

btw: webvirtmgr is awesome!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/293 **Author:** [@daniel-k](https://github.com/daniel-k) **Created:** 4/25/2014 **Status:** ✅ Merged **Merged:** 4/26/2014 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`dc40cba`](https://github.com/retspen/webvirtmgr/commit/dc40cba7b60a8b2d8051fea88a5895364e9da0d0) add vnc password clear - [`a6c3d0a`](https://github.com/retspen/webvirtmgr/commit/a6c3d0adb8fb262a41ed50b87b03e434f2ba1ac4) add vnc keymap setting, improve set_vnc_passwd and set_vnc_keymap - [`de1931f`](https://github.com/retspen/webvirtmgr/commit/de1931fc3fbd29026f1167a592847f323cd58de2) fix clear passwd/keymap when not set ### 📊 Changes **4 files changed** (+113 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `instance/views.py` (+15 -2) 📝 `templates/instance.html` (+64 -2) 📝 `vrtManager/instance.py` (+28 -7) 📝 `webvirtmgr/settings.py` (+6 -0) </details> ### 📄 Description Hello, I just added support for setting vnc keymap (as also requested by #140) and added the functionality to clear the vnc password. No real big changes, just an improvement in vrtManager/instance.py:wvmInstance.set_vnc_passwd. The old implementation used regex to manipulate the xml, I now use ElementTree, this is less messy and was needed so that you can set and reset password and keymap independently (other setting was deleted every time). Hope you like it, this is my first pull request on github :) btw: **webvirtmgr is awesome!** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>