mirror of
https://github.com/retspen/webvirtmgr.git
synced 2026-04-25 15:45:51 +03:00
[GH-ISSUE #614] cache_mode missing in form #467
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @purplesrl on GitHub (Jun 13, 2016).
Original GitHub issue: https://github.com/retspen/webvirtmgr/issues/614
when creating a new instance from a flavor cache_mode is not inserted in the template.html, but it is required in create/forms.py
cache_mode = forms.CharField(error_messages={'required': _('Please select HDD cache mode')})
Since the form.is_valid() function will fail, nothing will be created, it will just silently exit.
To fix this under
<input type="hidden" name="hdd_size" value="{{ flavor.disk }}">in template.html add:<input type="hidden" name="cache_mode" value="default">To completely fix this, when the flavor is created cache mode should be added.
@miguelwhite commented on GitHub (Jul 14, 2016):
@purplesrl Are you going to open a PR?
@xiangjl commented on GitHub (Aug 3, 2016):
@miguelwhite @purplesrl I fixed the issue,wait for pull request.
@cosu commented on GitHub (Sep 28, 2016):
See #625