mirror of
https://github.com/retspen/webvirtmgr.git
synced 2026-04-26 08:05:54 +03:00
[GH-ISSUE #407] Prevent hard-coded memory limits #304
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @michelkaeser on GitHub (Aug 30, 2014).
Original GitHub issue: https://github.com/retspen/webvirtmgr/issues/407
In https://github.com/retspen/webvirtmgr/blob/master/instance/views.py#L458 the memory limits are hard-coded and there is no way to manually set other values.
Suggestions:
conn.get_max_memory()to get the node's memory limit and then do a while loop with increment 1024 to add possible values. That way - on a 32GB server - one can set for example 24GB.@lub commented on GitHub (Sep 3, 2014):
Maybe it would be enough when you could choose a custom memory limit (in GB * 1024).
Then you could quickly select a common limit and specify a more or less uncommon for your use case.