starred/webvirtmgr
1
0
Fork 0
mirror of https://github.com/retspen/webvirtmgr.git synced 2026-04-26 08:05:54 +03:00
Code Issues 209 Projects Releases 7 Packages Wiki Activity

[GH-ISSUE #137] ISO storage pool uses case sensitive extensions #112

New issue
Closed
opened 2026-02-27 16:37:59 +03:00 by kerem · 1 comment
kerem commented 2026-02-27 16:37:59 +03:00
Owner
Copy link

Originally created by @cc-daveloper on GitHub (Oct 25, 2013).
Original GitHub issue: https://github.com/retspen/webvirtmgr/issues/137

The match for .iso and .img are case sensitive when they should be case insensitive to also match for .ISO and .IMG. The primary impetus is that M$ and others commonly distribute their images with the upper case .IMG extension.

Originally created by @cc-daveloper on GitHub (Oct 25, 2013). Original GitHub issue: https://github.com/retspen/webvirtmgr/issues/137 The match for .iso and .img are case sensitive when they should be case insensitive to also match for .ISO and .IMG. The primary impetus is that M$ and others commonly distribute their images with the upper case .IMG extension.
kerem closed this issue 2026-02-27 16:38:00 +03:00
kerem commented 2026-02-27 16:38:00 +03:00
Author
Owner
Copy link

@jansauerbrey commented on GitHub (Oct 27, 2013):

In addition to the upper behaiviour, I use LVM volumes which do not have any .img endings. So the check to show only *.img files within the storage pool results in no hdd entry for me.

Is it possible to remove or disable this check for img again since normally within your pool you should have only your images?

Thanks
Jan

P.S: I use ubuntu 12.04 and the newest version 3.3.4

P.P.S:

For my issue I checked the code and edited the server.py as follows:

$ diff server.py.ORIG server.py
277c277,280

< if stg.info()[0] != 0:

        stg_type = get_xml_path(stg.XMLDesc(0), "/pool/@type")
        if stg_type == 'logical':
  image_type = 'raw'
        elif stg.info()[0] != 0:

464,465c467,473
< for img in stg.listVolumes():

< if re.findall(".img", img):

            stg_type = get_xml_path(stg.XMLDesc(0), "/pool/@type")
            if stg_type == 'dir':
                for img in stg.listVolumes():
                    if re.findall(".img", img):
                        disk.append(img)
            else:
                for img in stg.listVolumes():

546c555,563

< if re.findall(".img", name) or re.findall(".iso", name):

        stg_type = get_xml_path(stg.XMLDesc(0), "/pool/@type")
        if stg_type == 'dir':
            if re.findall(".img", name) or re.findall(".iso", name):
                vol = stg.storageVolLookupByName(name)
                xml = vol.XMLDesc(0)
                size = vol.info()[1]
                volume_format = get_xml_path(xml, "/volume/target/format/@type")
                volume_info[name] = size, volume_format
        else:

First change addresses problems with apparmor when driver type is set to 'None'
Second and third change address missing handling of logical storage pools.

<!-- gh-comment-id:27170991 --> @jansauerbrey commented on GitHub (Oct 27, 2013): In addition to the upper behaiviour, I use LVM volumes which do not have any .img endings. So the check to show only *.img files within the storage pool results in no hdd entry for me. Is it possible to remove or disable this check for img again since normally within your pool you should have only your images? Thanks Jan P.S: I use ubuntu 12.04 and the newest version 3.3.4 P.P.S: For my issue I checked the code and edited the server.py as follows: --- $ diff server.py.ORIG server.py 277c277,280 ## < if stg.info()[0] != 0: > ``` > stg_type = get_xml_path(stg.XMLDesc(0), "/pool/@type") > if stg_type == 'logical': > image_type = 'raw' > elif stg.info()[0] != 0: > ``` > > 464,465c467,473 > < for img in stg.listVolumes(): > > ## < if re.findall(".img", img): > > ``` > stg_type = get_xml_path(stg.XMLDesc(0), "/pool/@type") > if stg_type == 'dir': > for img in stg.listVolumes(): > if re.findall(".img", img): > disk.append(img) > else: > for img in stg.listVolumes(): > ``` > > 546c555,563 > > ## < if re.findall(".img", name) or re.findall(".iso", name): > > ``` > stg_type = get_xml_path(stg.XMLDesc(0), "/pool/@type") > if stg_type == 'dir': > if re.findall(".img", name) or re.findall(".iso", name): > vol = stg.storageVolLookupByName(name) > xml = vol.XMLDesc(0) > size = vol.info()[1] > volume_format = get_xml_path(xml, "/volume/target/format/@type") > volume_info[name] = size, volume_format > else: > ``` > > --- First change addresses problems with apparmor when driver type is set to 'None' Second and third change address missing handling of logical storage pools.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
v4.8.9
v4.8.8
4.8.7
v4.1.0
v4.0.1
v3.0.0
v2.3.2
Labels
Clear labels   
bug

   
pull-request

Mirrored from GitHub Pull Request

  
wontfix
No labels
bug
pull-request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/webvirtmgr#112
No description provided.