[PR #611] [MERGED] Get MAC OUI from settings.py #642

New issue

Closed

opened 2026-02-27 15:59:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:59:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/611
Author: @MisterBlueBear
Created: 10/18/2023
Status: ✅ Merged
Merged: 10/20/2023
Merged by: @catborise

Base: master ← Head: MAC_OUI

📝 Commits (1)

5a211c0 Get MAC OUI from settings.py

📊 Changes

3 files changed (+11 additions, -5 deletions)

View changed files

📝 instances/utils.py (+1 -1)
📝 vrtManager/util.py (+8 -4)
📝 webvirtcloud/settings.py.template (+2 -0)

📄 Description

Removed the hard coded MAC OUI in the code and instead fetches the OUI from settings.py

If independent instances of WebVirtCloud (or any libvirt) exists on the same subnet and VMs are configured to use a bridge interface, this could lead to duplicate MACs on the same subnet (low probability, but still possible).
This change gives the user a choice to define an OUI.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/611 **Author:** [@MisterBlueBear](https://github.com/MisterBlueBear) **Created:** 10/18/2023 **Status:** ✅ Merged **Merged:** 10/20/2023 **Merged by:** [@catborise](https://github.com/catborise) **Base:** `master` ← **Head:** `MAC_OUI` --- ### 📝 Commits (1) - [`5a211c0`](https://github.com/retspen/webvirtcloud/commit/5a211c0c566f1b9ec64a0cf356672eb776058cf3) Get MAC OUI from settings.py ### 📊 Changes **3 files changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `instances/utils.py` (+1 -1) 📝 `vrtManager/util.py` (+8 -4) 📝 `webvirtcloud/settings.py.template` (+2 -0) </details> ### 📄 Description Removed the hard coded MAC OUI in the code and instead fetches the OUI from settings.py If independent instances of WebVirtCloud (or any libvirt) exists on the same subnet and VMs are configured to use a bridge interface, this could lead to duplicate MACs on the same subnet (low probability, but still possible). This change gives the user a choice to define an OUI. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>