[PR #600] [MERGED] Switch to django-auth-ldap for LDAP authentication #636

New issue

Closed

opened 2026-02-27 15:59:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:59:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/600
Author: @krejcar25
Created: 9/11/2023
Status: ✅ Merged
Merged: 9/13/2023
Merged by: @catborise

Base: master ← Head: master

📝 Commits (3)

01a4225 Add django-auth-ldap dependency
74ee2c0 Remove old LDAP backend files
561fedf Add new template config and README blocks

📊 Changes

5 files changed (+70 additions, -213 deletions)

View changed files

📝 README.md (+46 -28)
📝 conf/requirements.txt (+1 -0)
➖ webvirtcloud/.dec_ldap_pwd.sh (+0 -18)
➖ webvirtcloud/ldapbackend.py (+0 -142)
📝 webvirtcloud/settings.py.template (+23 -25)

📄 Description

This PR removes the locally maintained LDAP auth backend and replaces it with the widely-used django-auth-ldap library.

All template config was maintained and ported to be useable with this library, moreover a separate AD and OpenLDAP version was provided.

These changes were tested with both AD and OpenLDAP.

This PR would also close old #243.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/600 **Author:** [@krejcar25](https://github.com/krejcar25) **Created:** 9/11/2023 **Status:** ✅ Merged **Merged:** 9/13/2023 **Merged by:** [@catborise](https://github.com/catborise) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`01a4225`](https://github.com/retspen/webvirtcloud/commit/01a4225a84970c48c426dd1d2c36d5091adf6868) Add django-auth-ldap dependency - [`74ee2c0`](https://github.com/retspen/webvirtcloud/commit/74ee2c073a05995d454a5c35a753d92f43a179f7) Remove old LDAP backend files - [`561fedf`](https://github.com/retspen/webvirtcloud/commit/561fedfccd4ec8a04174af644ab6c29a605a9bbf) Add new template config and README blocks ### 📊 Changes **5 files changed** (+70 additions, -213 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+46 -28) 📝 `conf/requirements.txt` (+1 -0) ➖ `webvirtcloud/.dec_ldap_pwd.sh` (+0 -18) ➖ `webvirtcloud/ldapbackend.py` (+0 -142) 📝 `webvirtcloud/settings.py.template` (+23 -25) </details> ### 📄 Description This PR removes the locally maintained LDAP auth backend and replaces it with the widely-used [django-auth-ldap](https://github.com/django-auth-ldap/django-auth-ldap) library. All template config was maintained and ported to be useable with this library, moreover a separate AD and OpenLDAP version was provided. These changes were tested with both AD and OpenLDAP. This PR would also close old #243. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>