[PR #411] [MERGED] instance network change #545

New issue

Closed

opened 2026-02-27 15:59:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:59:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/411
Author: @catborise
Created: 2/25/2021
Status: ✅ Merged
Merged: 2/25/2021
Merged by: @catborise

Base: master ← Head: master

📝 Commits (2)

2f1b11b reorganize host interfaces. remove it from instance methods
fa4a314 fix network add and change methods to handle bridge/mavctap differentation correctly.

📊 Changes

8 files changed (+72 additions, -33 deletions)

View changed files

📝 instances/models.py (+0 -4)
📝 instances/templates/add_instance_network_block.html (+1 -1)
📝 instances/templates/instances/settings_tab.html (+1 -1)
📝 instances/views.py (+22 -0)
📝 interfaces/views.py (+2 -1)
📝 vrtManager/connection.py (+2 -2)
📝 vrtManager/instance.py (+38 -17)
📝 vrtManager/interface.py (+6 -7)

📄 Description

There is a bug with related instance network change. if user want to change interface from bridge to defined libvirt network, it was causes error. it is fixed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/411 **Author:** [@catborise](https://github.com/catborise) **Created:** 2/25/2021 **Status:** ✅ Merged **Merged:** 2/25/2021 **Merged by:** [@catborise](https://github.com/catborise) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`2f1b11b`](https://github.com/retspen/webvirtcloud/commit/2f1b11b3caefae61e398b8dcec97da438f416188) reorganize host interfaces. remove it from instance methods - [`fa4a314`](https://github.com/retspen/webvirtcloud/commit/fa4a3149c91a0a2a9bea96f4d9eee34be86b54bd) fix network add and change methods to handle bridge/mavctap differentation correctly. ### 📊 Changes **8 files changed** (+72 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `instances/models.py` (+0 -4) 📝 `instances/templates/add_instance_network_block.html` (+1 -1) 📝 `instances/templates/instances/settings_tab.html` (+1 -1) 📝 `instances/views.py` (+22 -0) 📝 `interfaces/views.py` (+2 -1) 📝 `vrtManager/connection.py` (+2 -2) 📝 `vrtManager/instance.py` (+38 -17) 📝 `vrtManager/interface.py` (+6 -7) </details> ### 📄 Description There is a bug with related instance network change. if user want to change interface from bridge to defined libvirt network, it was causes error. it is fixed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>