[PR #324] [MERGED] Some improvements for appsettings app #500

Closed
opened 2026-02-27 15:58:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/324
Author: @Real-Gecko
Created: 6/17/2020
Status: Merged
Merged: 6/18/2020
Merged by: @retspen

Base: masterHead: master


📝 Commits (2)

  • bb8f95b Some improvements for appsettings app
  • eda233a Fix appsettings

📊 Changes

6 files changed (+44 additions, -4 deletions)

View changed files

appsettings/admin.py (+0 -3)
appsettings/context_processors.py (+13 -0)
appsettings/middleware.py (+10 -0)
appsettings/settings.py (+18 -0)
📝 instances/templates/instance.html (+1 -1)
📝 webvirtcloud/settings.py.template (+2 -0)

📄 Description

Note that settings.py now require 'appsettings.middleware.AppSettingsMiddleware', and 'appsettings.context_processors.app_settings', in MIDDLEWARE and context_processors respectively.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/324 **Author:** [@Real-Gecko](https://github.com/Real-Gecko) **Created:** 6/17/2020 **Status:** ✅ Merged **Merged:** 6/18/2020 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`bb8f95b`](https://github.com/retspen/webvirtcloud/commit/bb8f95be148d5905bf5a624cd62c4d4ee1f22f86) Some improvements for appsettings app - [`eda233a`](https://github.com/retspen/webvirtcloud/commit/eda233ada739353d6ebd490bf2b1fa68aabdae46) Fix appsettings ### 📊 Changes **6 files changed** (+44 additions, -4 deletions) <details> <summary>View changed files</summary> ➖ `appsettings/admin.py` (+0 -3) ➕ `appsettings/context_processors.py` (+13 -0) ➕ `appsettings/middleware.py` (+10 -0) ➕ `appsettings/settings.py` (+18 -0) 📝 `instances/templates/instance.html` (+1 -1) 📝 `webvirtcloud/settings.py.template` (+2 -0) </details> ### 📄 Description Note that settings.py now require `'appsettings.middleware.AppSettingsMiddleware',` and `'appsettings.context_processors.app_settings',` in `MIDDLEWARE` and `context_processors` respectively. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 15:58:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/webvirtcloud#500
No description provided.