[PR #322] [MERGED] Minor fixes and more tests #499

New issue

Closed

opened 2026-02-27 15:58:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/322
Author: @Real-Gecko
Created: 6/15/2020
Status: ✅ Merged
Merged: 6/17/2020
Merged by: @retspen

Base: master ← Head: master

📝 Commits (10+)

ca3b880 Updated requiremets and added dev reqs
cfd7397 Added missing migrations
9a75ceb Replaced unicode with str for models
e4e86ed replaced django-fa with django-icons
354163f Added pagination to logs list template
68f7376 Moved confirm_delete.html to project templates
a4d28f2 Reworked some computes views and added more tests
d3c59ac More tests for computes
20d4aaa Removed UserAddForm as it is not used
2951d0b Cleaned up UserAttributes model

📊 Changes

50 files changed (+806 additions, -710 deletions)

View changed files

📝 accounts/forms.py (+29 -25)
➕ accounts/migrations/0004_auto_20200615_0637.py (+44 -0)
➕ accounts/migrations/0005_auto_20200616_1039.py (+20 -0)
📝 accounts/models.py (+8 -26)
📝 accounts/templates/account.html (+65 -122)
➕ accounts/templates/accounts/change_password_form.html (+29 -0)
➖ accounts/templates/create_user_inst_block.html (+0 -36)
📝 accounts/templates/profile.html (+4 -28)
📝 accounts/tests.py (+38 -2)
📝 accounts/urls.py (+6 -1)
📝 accounts/views.py (+76 -60)
📝 admin/templates/admin/common/list.html (+1 -1)
📝 admin/templates/admin/group_list.html (+1 -1)
📝 admin/templates/admin/logs.html (+2 -1)
📝 admin/templates/admin/user_form.html (+1 -1)
📝 admin/templates/admin/user_list.html (+1 -1)
📝 admin/views.py (+19 -5)
➕ appsettings/migrations/0003_auto_20200615_0637.py (+38 -0)
📝 computes/forms.py (+0 -28)
➕ computes/migrations/0003_auto_20200615_0637.py (+38 -0)

...and 30 more files

📄 Description

I think it will be better to redo all the migrations before we hit next release.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/322 **Author:** [@Real-Gecko](https://github.com/Real-Gecko) **Created:** 6/15/2020 **Status:** ✅ Merged **Merged:** 6/17/2020 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`ca3b880`](https://github.com/retspen/webvirtcloud/commit/ca3b88097e4251f85c6c469576a9aa80199b18d6) Updated requiremets and added dev reqs - [`cfd7397`](https://github.com/retspen/webvirtcloud/commit/cfd739778c2a683bb0b3e3afd71134f3f3ff88fe) Added missing migrations - [`9a75ceb`](https://github.com/retspen/webvirtcloud/commit/9a75ceb0e5d9b96c4652ceddc8c3980bbb92c4cb) Replaced __unicode__ with __str__ for models - [`e4e86ed`](https://github.com/retspen/webvirtcloud/commit/e4e86ed576e483d9e821088f5e55633569a283eb) replaced django-fa with django-icons - [`354163f`](https://github.com/retspen/webvirtcloud/commit/354163fa1de9bbe4bc9494db9048c1ed6ea0e6e7) Added pagination to logs list template - [`68f7376`](https://github.com/retspen/webvirtcloud/commit/68f7376d15ddab453b6ca0e99b9cd874e3316a30) Moved confirm_delete.html to project templates - [`a4d28f2`](https://github.com/retspen/webvirtcloud/commit/a4d28f295361cd738a34e8affba388d8a10127f5) Reworked some computes views and added more tests - [`d3c59ac`](https://github.com/retspen/webvirtcloud/commit/d3c59acb3f2f0ef5bbb4e89688352c522a994956) More tests for computes - [`20d4aaa`](https://github.com/retspen/webvirtcloud/commit/20d4aaac30cb79d516e402513fd6de4e24e97856) Removed UserAddForm as it is not used - [`2951d0b`](https://github.com/retspen/webvirtcloud/commit/2951d0b03541e7dc86e2624e971ed11d937f6619) Cleaned up UserAttributes model ### 📊 Changes **50 files changed** (+806 additions, -710 deletions) <details> <summary>View changed files</summary> 📝 `accounts/forms.py` (+29 -25) ➕ `accounts/migrations/0004_auto_20200615_0637.py` (+44 -0) ➕ `accounts/migrations/0005_auto_20200616_1039.py` (+20 -0) 📝 `accounts/models.py` (+8 -26) 📝 `accounts/templates/account.html` (+65 -122) ➕ `accounts/templates/accounts/change_password_form.html` (+29 -0) ➖ `accounts/templates/create_user_inst_block.html` (+0 -36) 📝 `accounts/templates/profile.html` (+4 -28) 📝 `accounts/tests.py` (+38 -2) 📝 `accounts/urls.py` (+6 -1) 📝 `accounts/views.py` (+76 -60) 📝 `admin/templates/admin/common/list.html` (+1 -1) 📝 `admin/templates/admin/group_list.html` (+1 -1) 📝 `admin/templates/admin/logs.html` (+2 -1) 📝 `admin/templates/admin/user_form.html` (+1 -1) 📝 `admin/templates/admin/user_list.html` (+1 -1) 📝 `admin/views.py` (+19 -5) ➕ `appsettings/migrations/0003_auto_20200615_0637.py` (+38 -0) 📝 `computes/forms.py` (+0 -28) ➕ `computes/migrations/0003_auto_20200615_0637.py` (+38 -0) _...and 30 more files_ </details> ### 📄 Description I think it will be better to redo all the migrations before we hit next release. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>